-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Expand stops filters to include routes at stops #2131
Conversation
d47fbd3
to
aac7207
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may have missed or misunderstood something, but I was under the impression from previous discussions that re-implementing the API's "alert matching" logic within our cache was specifically something we wanted to avoid — with the reasoning that, in most cases where we fetch alerts, we already have the needed context of route type/route/stop/direction handy, and could pass those as explicit filters to the cache functions (which would be taken literally, not "expanded"). I don't disagree with this approach, just wondering how we arrived here.
EDIT: Taking the approach of being as compatible as possible with how the V3 API works, so we have greater confidence we're not changing the behavior of any existing uses of alert fetching in our app.
8042c3f
to
3fb90a0
Compare
3fb90a0
to
b05e2af
Compare
b05e2af
to
d116146
Compare
Adds `fetch_routes_for_stops/1` and uses that to expand a `stops:` filter similar to the V3 API.
d116146
to
f53e952
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚉 🔍 ✅
Adds
fetch_routes_for_stops/1
and uses that to expand astops:
filter similar to the V3 API.