Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable frontend source maps in Sentry #2164

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

digitalcora
Copy link
Contributor

@digitalcora digitalcora commented Aug 27, 2024

  • Upload source maps in parallel as part of the deploy Action.
  • Removes unneeded options from TerserPlugin. There is no such option as cache (this did nothing?), and parallel defaults to true.
  • Removes an old script that appears to have been previously used to upload source maps, but was not referenced anywhere.

Unfortunately the source maps this gives us aren't very good yet, because the source code as seen by Sentry appears to be just the pre-minification JS, which is downstream from TypeScript, all the polyfills, etc. But this is an unplanned task I didn't want to sink too much time into, and it's strictly better than what we had before.


* Upload source maps in parallel as part of the deploy Action.

* Removes unneeded options from TerserPlugin. There is no such option as
  `cache` (this did nothing?), and `parallel` defaults to true.

* Removes an old script that appears to have been previously used to
  upload source maps, but was not referenced anywhere.
@digitalcora digitalcora marked this pull request as ready for review August 27, 2024 20:47
@digitalcora digitalcora requested a review from a team as a code owner August 27, 2024 20:47
Copy link
Contributor

@cmaddox5 cmaddox5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@digitalcora digitalcora merged commit a288a7d into main Aug 29, 2024
14 checks passed
@digitalcora digitalcora deleted the cfg-fix-sourcemaps branch August 29, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants