Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused alert caching code #2165

Merged
merged 1 commit into from
Aug 28, 2024
Merged

chore: remove unused alert caching code #2165

merged 1 commit into from
Aug 28, 2024

Conversation

sloanelybutsurely
Copy link
Contributor

Ultimately the cache wasn't definitively faster than just fetching from the API directly. This removes the unused code.

@sloanelybutsurely sloanelybutsurely requested a review from a team as a code owner August 27, 2024 20:33
cmaddox5
cmaddox5 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@cmaddox5 cmaddox5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎻

I see a compilation error in a test but will go ahead so you can merge right after fixing.

@sloanelybutsurely sloanelybutsurely merged commit 0180877 into main Aug 28, 2024
11 checks passed
@sloanelybutsurely sloanelybutsurely deleted the sloane/push-zwqsqplzlnov branch August 28, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaddox5 cmaddox5 cmaddox5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sloanelybutsurely @cmaddox5