fix: filter cancelled & skipped departures #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parses the `schedule_relationship` field for `Predictions` and uses that data to remove departures with a SKIPPED or CANCELLED schedule relationship when merging `Prediction`s and `Schedule`s. Some Predictions now have a SKIPPED schedule relationship **AND** arrival/departure times (indicating what time the vehicle is predicted to pass through the stop). These Predictions need to be filtered out when we fetch departures. Previously these didn't have times so our other filtering logic would remove them. For completeness we are also filtering out Predictions with a CANCELLED schedule relationship.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parses the
schedule_relationshipfield forPredictionsand uses that data to remove departures with a SKIPPED or CANCELLED schedule relationship when mergingPredictions andSchedules.Some Predictions now have a SKIPPED schedule relationship AND arrival/departure times (indicating what time the vehicle is predicted to pass through the stop). These Predictions need to be filtered out when we fetch departures. Previously these didn't have times so our other filtering logic would remove them.
For completeness we are also filtering out Predictions with a CANCELLED schedule relationship.
Asana task: Filter out cancelled/skipped departures on Screens