chore: use SIGNS_UI_S3_BUCKET environment variable

[sloanelybutsurely]

References the new environment variable from https://github.com/mbta/devops/pull/2129 instead of deriving this value based on ENVIRONMENT_NAME

Warning

https://github.com/mbta/devops/pull/2129 must be deployed first! Update: This is done ✅

[cmaddox5]

A small thing I noticed. SignsUI dev and dev-green share the same bucket but use different config files (which we store in config.exs under :signs_ui_s3_path), with the only difference being dev -> config.json and dev-green -> config-dev-green.json. Can we also make the change to reflect that here?

[digitalcora]

Given the existing logic was to always use the config for dev and not dev-green when pointed at the "dev bucket", I'd be fine with leaving that as it is for this change — no need to introduce more environment variables / configuration unless we have a known use case for them.

[sloanelybutsurely]

SignsUI dev and dev-green share the same bucket but use different config files (which we store in config.exs under :signs_ui_s3_path), with the only difference being dev -> config.json and dev-green -> config-dev-green.json.

@cmaddox5 Where do you see this? I only see one place where signs_ui_s3_path is set.

screens/config/config.exs

Line 71 in b3523ed

signs_ui_s3_path: "config.json",

🔍 Code search for signs_ui_s3_path

[cmaddox5]

@sloanelybutsurely I was referencing the actual config name for each environment in SignsUI. So technically, we aren't matching up our dev-green environment to the correct config. But I agree with Cora, this is a different issue so it can be deferred to a later change if needed.

[sloanelybutsurely]

Just waiting on the infra changes to be applied to prod before merging