chore: remove bespoke routes-at-stop retry logic #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some time ago (36f9f83) we changed this specific data fetching function so it "doesn't trust" the V3 API if it says there are no routes serving a stop, and tries again up to 3 times. Some more-recent time ago (297c302), as part of a refactor of this function, we added a warning when a retry occurs, so we'd get some idea whether this logic was still useful. One month later, we have not logged this warning in any deployed environment, so it seems safe to remove.
sloanelybutsurely
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago (36f9f83) we changed this specific data fetching function so it "doesn't trust" the V3 API if it says there are no routes serving a stop, and tries again up to 3 times.
Some more-recent time ago (297c302), as part of a refactor of this function, we added a warning when a retry occurs, so we'd get some idea whether this logic was still useful.
One month later, we have not logged this warning in any deployed environment, so it seems safe to remove.