Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove Triptychs #2203

Merged
merged 3 commits into from
Sep 16, 2024
Merged

chore: Remove Triptychs #2203

merged 3 commits into from
Sep 16, 2024

Conversation

cmaddox5
Copy link
Contributor

The Triptych app is dead. Removing all code.

@cmaddox5 cmaddox5 requested a review from a team as a code owner September 16, 2024 14:06
@digitalcora
Copy link
Contributor

Looks like we've got quite the batch of conflicts here. Sorry for the shake-up, I think that's my fault.

@cmaddox5
Copy link
Contributor Author

No problem! I think I resolved all of it.

assets/src/components/v2/dup/README.md Outdated Show resolved Hide resolved
assets/src/util/outfront.tsx Outdated Show resolved Hide resolved
lib/screens_web/controllers/v2/screen_api_controller.ex Outdated Show resolved Hide resolved
Copy link
Contributor

@digitalcora digitalcora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's deploy this to dev-green and make sure nothing crashes, and maybe also give the DUP packaging process another run-through and ensure it still works as a file://. Other than that, this looks good. Any day where you get to delete 3,500 lines is a good day!

@cmaddox5
Copy link
Contributor Author

DUP packaging looks good:
dup-app-0.zip
dup-app-1.zip
dup-app-2.zip

Will let the branch sit on dev-green for a bit before merging.

@cmaddox5 cmaddox5 merged commit a63676c into main Sep 16, 2024
14 checks passed
@cmaddox5 cmaddox5 deleted the cm/remove-triptych-code branch September 16, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants