Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix vendors in config #2237

Merged
merged 2 commits into from
Oct 8, 2024
Merged

chore: Fix vendors in config #2237

merged 2 commits into from
Oct 8, 2024

Conversation

cmaddox5
Copy link
Contributor

@cmaddox5 cmaddox5 commented Oct 8, 2024

This PR updates screens-config-lib so we can correctly flag invalid vendors. I also found that the admin tool was using lg-mri instead of lg_mri that the config expects.

@cmaddox5 cmaddox5 requested a review from a team as a code owner October 8, 2024 18:28
digitalcora
digitalcora approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@digitalcora digitalcora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch with the -/_!

@cmaddox5 cmaddox5 merged commit 4d3c82b into main Oct 8, 2024
13 checks passed
@cmaddox5 cmaddox5 deleted the cm/fix-vendors branch October 8, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digitalcora digitalcora digitalcora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaddox5 @digitalcora