-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Elevator Happy Path #2248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach seems fine to me — though I do wonder if we should be pre-emptively splitting the distinct "parts" we've already identified here (header, content, footer) into separate widgets on the backend, so e.g. we could have a piece of evergreen content replace only the main content area, and not have to add "hard-coded" copies of the header and footer to make it look right. Up to you, I think it would be a similar effort to do that now or do it later.
That's a good point. I didn't think about evergreen enough when building this out. I'll go ahead and do that now so we have a finalized layout before starting the harder work later. |
4eaba08
to
ff876a2
Compare
Created the new Elevator screen widget with a hardcoded "happy path". At the moment, it only sends the configured ID, current time, and empty lists of alerts. I used these designs to guide the implementation.
https://screens-dev-green.mbtace.com/v2/screen/ELE-101