Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Elevator Happy Path #2248

Merged
merged 10 commits into from
Oct 21, 2024
Merged

feat: Elevator Happy Path #2248

merged 10 commits into from
Oct 21, 2024

Conversation

cmaddox5
Copy link
Contributor

@cmaddox5 cmaddox5 commented Oct 16, 2024

Created the new Elevator screen widget with a hardcoded "happy path". At the moment, it only sends the configured ID, current time, and empty lists of alerts. I used these designs to guide the implementation.

https://screens-dev-green.mbtace.com/v2/screen/ELE-101


@cmaddox5 cmaddox5 requested a review from a team as a code owner October 16, 2024 15:43
Copy link
Contributor

@digitalcora digitalcora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach seems fine to me — though I do wonder if we should be pre-emptively splitting the distinct "parts" we've already identified here (header, content, footer) into separate widgets on the backend, so e.g. we could have a piece of evergreen content replace only the main content area, and not have to add "hard-coded" copies of the header and footer to make it look right. Up to you, I think it would be a similar effort to do that now or do it later.

@cmaddox5
Copy link
Contributor Author

That's a good point. I didn't think about evergreen enough when building this out. I'll go ahead and do that now so we have a finalized layout before starting the harder work later.

@cmaddox5 cmaddox5 merged commit 5e9ea4f into main Oct 21, 2024
11 checks passed
@cmaddox5 cmaddox5 deleted the cm/elevator-happy-path branch October 21, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants