fix: Recon error workaround. #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalcora
approved these changes
Oct 28, 2024
lib/screens/health.ex
Outdated
| |> Stream.map(fn {metric, value} -> "#{metric}=#{value}" end) | ||
| |> Enum.intersperse(" ") | ||
|
|
||
| {name, supervisor, metrics} | ||
| end | ||
|
|
||
| # work around https://github.com/ferd/recon/issues/95 | ||
| # The issue is closed but is still very much an issue. |
There was a problem hiding this comment.
Rather than putting an assertion like this in a comment where it can drift apart from the actual status of the issue, I'd prefer updating the issue itself, which I've just done. (at some later time, presumably, the issue will be closed and fixed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the first PR, I removed this workaround because the author closed Cora's original issue. This is definitely still an issue. I deployed the health check on Friday and saw the error occur about 60 times. Want to get this workaround in before deploying the check to prod.