feat: suppress periodic audio in inspector #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids being jumpscared by a periodic audio readout that also can't be silenced, short of closing the tab or navigating away. To replace the missing feedback on whether periodic audio is configured, also adds a line to the inspector audio controls to report the readout parameters that would have been used.
digitalcora
force-pushed
the
cfg-inspector-audio
branch
from
940aaa1
to
f296a61
Compare
cmaddox5
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids being jumpscared by a periodic audio readout that also can't be silenced, short of closing the tab or navigating away. To replace the missing feedback on whether periodic audio is configured, also adds a line to the inspector audio controls to report the readout parameters that would have been used.