Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: qa 및 uxqa에서 나온 이슈 사항을 수정하라 #464

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

saseungmin
Copy link
Member

  • 읽지 않은 알람 리스트 배경 색상 변경
  • 글 리스트 최신순 정렬 (작성일시 기준)
  • 토스트 메시지 PC에서는 가운데에 위치하도록 수정하고 위에서 아래로 나오도록 통일
  • 모바일일 때 토스트 메시지 CSS 수정
  • 모바일일 때 시작하기(sign up) 페이지, 홈 리스트 페이지는 좌우 margin 20px 나머지는 16px
  • 모달 background opacity 0.4로 변경, 토스트 메시지 background opacity 0.95로 변경

- 읽지 않은 알람 리스트 배경 색상 변경
- 글 리스트 최신순 정렬 (작성일시 기준)
- 토스트 메시지 PC에서는 가운데에 위치하도록 수정하고 위에서 아래로 나오도록 통일
- 모바일일 때 토스트 메시지 CSS 수정
- 모바일일 때 시작하기(sign up) 페이지, 홈 리스트 페이지는 좌우 margin 20px 나머지는 16px
- 모달 background opacity 0.4로 변경, 토스트 메시지 background opacity 0.95로 변경
@vercel
Copy link

vercel bot commented Sep 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
soople ✅ Ready (Inspect) Visit Preview Sep 8, 2022 at 2:02PM (UTC)

@saseungmin saseungmin added Bugfix/UI UI관련 Bug 수정 Bugfix/Function Fix to bug and isn't working and removed size/M labels Sep 8, 2022
@saseungmin saseungmin linked an issue Sep 8, 2022 that may be closed by this pull request
13 tasks
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Bundle Sizes

Compared against 0990ce6

Route: No significant changes found

Dynamic import: No significant changes found

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #464 (ea5f353) into main (0990ce6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #464   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          186       186           
  Lines         3328      3328           
  Branches       341       341           
=========================================
  Hits          3328      3328           
Impacted Files Coverage Δ
src/components/alarm/AlarmItem.tsx 100.00% <ø> (ø)
src/components/auth/SignInModal.tsx 100.00% <ø> (ø)
src/components/common/ConfirmModal.tsx 100.00% <ø> (ø)
src/components/common/Core.tsx 100.00% <ø> (ø)
src/components/common/FormModal.tsx 100.00% <ø> (ø)
src/components/common/ViewModalWindow.tsx 100.00% <ø> (ø)
src/containers/auth/SignUpContainer.tsx 100.00% <ø> (ø)
src/pages/index.page.tsx 100.00% <ø> (ø)
src/services/firebase/getQuery.ts 100.00% <ø> (ø)
src/styles/Layout.tsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

⚡️ 1 Lighthouse report!

Category Score
🔴 Performance 40
🟢 Accessibility 90
🟢 Best Practices 92
🟢 SEO 100
🟠 PWA 80
Category Score
🟢 First Contentful Paint 1.6 s
🔴 Time to Interactive 10.8 s
🟢 Speed Index 2.7 s
🔴 Total Blocking Time 1,580 ms
🔴 Largest Contentful Paint 9.1 s
🟢 Cumulative Layout Shift 0

⚡️ 2 Lighthouse report!

Category Score
🔴 Performance 46
🟢 Accessibility 90
🟢 Best Practices 92
🟢 SEO 100
🟠 PWA 80
Category Score
🟢 First Contentful Paint 1.6 s
🔴 Time to Interactive 9.8 s
🟢 Speed Index 1.6 s
🔴 Total Blocking Time 1,010 ms
🔴 Largest Contentful Paint 7.6 s
🟢 Cumulative Layout Shift 0

⚡️ 3 Lighthouse report!

Category Score
🔴 Performance 44
🟢 Accessibility 90
🟢 Best Practices 92
🟢 SEO 100
🟠 PWA 80
Category Score
🟢 First Contentful Paint 1.6 s
🔴 Time to Interactive 9.8 s
🟢 Speed Index 2.3 s
🔴 Total Blocking Time 1,280 ms
🔴 Largest Contentful Paint 7.5 s
🟢 Cumulative Layout Shift 0

@saseungmin saseungmin merged commit 23b31b3 into main Sep 8, 2022
@saseungmin saseungmin deleted the fix/issue-463 branch September 8, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix/Function Fix to bug and isn't working Bugfix/UI UI관련 Bug 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2022.09.07 미팅에 나온 수정 사항
1 participant