Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 접근 권한이 없는 사용자가 signup 페이지에 접근했을때 홈으로 redirect시키도록 하라 #467

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

saseungmin
Copy link
Member

  • 회원가입을 하지 않은 사용자, 비로그인인 사용자가 sign up 페이지에 접근했을 때 홈으로 redirected
  • 홈으로 redirect시키고 "접근 권한이 없는 페이지에요." 에러 토스트 메시지를 띄운다.

- 회원가입을 하지 않은 사용자, 비로그인인 사용자가 sign up 페이지에 접근했을 때 홈으로 redirected
- 홈으로 redirect시키고 "접근 권한이 없는 페이지에요." 에러 토스트 메시지를 띄운다.
@vercel
Copy link

vercel bot commented Sep 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
soople ✅ Ready (Inspect) Visit Preview Sep 10, 2022 at 9:57AM (UTC)

@github-actions
Copy link

Bundle Sizes

Compared against a2efd79

Route: No significant changes found

Dynamic import: No significant changes found

@codecov
Copy link

codecov bot commented Sep 10, 2022

Codecov Report

Merging #467 (af79ebd) into main (a2efd79) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #467   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          187       187           
  Lines         3334      3337    +3     
  Branches       340       340           
=========================================
+ Hits          3334      3337    +3     
Impacted Files Coverage Δ
src/components/auth/SignUpForm.tsx 100.00% <ø> (ø)
...es/serverSideProps/authenticatedServerSideProps.ts 100.00% <ø> (ø)
src/containers/auth/SignUpContainer.tsx 100.00% <100.00%> (ø)
src/pages/signup.page.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

⚡️ 1 Lighthouse report!

Category Score
🟠 Performance 52
🟢 Accessibility 90
🟢 Best Practices 92
🟢 SEO 100
🟠 PWA 80
Category Score
🟢 First Contentful Paint 1.6 s
🔴 Time to Interactive 9.4 s
🟢 Speed Index 2.4 s
🔴 Total Blocking Time 630 ms
🔴 Largest Contentful Paint 8.6 s
🟢 Cumulative Layout Shift 0

⚡️ 2 Lighthouse report!

Category Score
🔴 Performance 47
🟢 Accessibility 90
🟢 Best Practices 92
🟢 SEO 100
🟠 PWA 80
Category Score
🟢 First Contentful Paint 1.6 s
🔴 Time to Interactive 10.2 s
🟢 Speed Index 1.9 s
🔴 Total Blocking Time 910 ms
🔴 Largest Contentful Paint 7.8 s
🟢 Cumulative Layout Shift 0

⚡️ 3 Lighthouse report!

Category Score
🔴 Performance 47
🟢 Accessibility 90
🟢 Best Practices 92
🟢 SEO 100
🟠 PWA 80
Category Score
🟢 First Contentful Paint 1.6 s
🔴 Time to Interactive 10.0 s
🟢 Speed Index 2.5 s
🔴 Total Blocking Time 890 ms
🔴 Largest Contentful Paint 7.9 s
🟢 Cumulative Layout Shift 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2022.09.07 미팅에 나온 수정 사항
1 participant