-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add config for pre-commit #244
Conversation
Related to #242
could you tell me if this work if you add it to your .pre-commit-config.yaml - repo: https://github.com/ccoveille/unmake
rev: 38b03e7cbe1c28bcb8d33c1b2dcff8f50bf743ad
hooks:
- id: unmake |
I will assume you are not interested and somehow rude. Bye, great tool anyway. |
This seems to work, thanks! |
OK so, the PR only have to be merged and it would work without any further work with the following code to be used by anyone who would like to use - repo: https://github.com/mcandre/unmake
rev: v0.0.17
hooks:
- id: unmake So if @mcandre would reconsider merging it, it would be all set. |
Does the pre-commit system really require inserting code into the source code of the tool it's trying to wrap?! More bad design. No one has mentioned forking unmake. You can do this as well. I'm certainly not splashing any such nonsense in this repo. |
No, precommit doesn't require it. It just way you could provide guidance for people to use unmake with precommit. It's the same way, you are documenting things. But anyway, I won't argue as it seems there is nothing I can do to convince you people using precommit who loves your tool would expect and appreciate having an official support and guidance for using your tool with precommit. You make me feel you somehow hate tge fact precommit exists, and give a solution for a need. I quit. Respectfully |
For anyone interested, here is the repository I made to support unmake in pre-commit. https://github.com/ccoVeille/pre-commit-unmake I'm looking for testers |
Related to #242