Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node field calls in 'sim_bridge/unity_bridge.py' #664

Open
Alb33rt opened this issue Nov 16, 2024 · 0 comments
Open

Fix node field calls in 'sim_bridge/unity_bridge.py' #664

Alb33rt opened this issue Nov 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Alb33rt
Copy link
Contributor

Alb33rt commented Nov 16, 2024

Problem

As we know, ROS2 utilizes node classes for defining abstract "nodes" in a ROS Graph. This paradigm shift is in contrast to ROS1's simple and pure function definitions and calls. Because of this, nodes have attributes/fields that would otherwise be considered "global" in the context of ROS1.

In unity_bridge.py of the package sim_bridge. Fix the function calls so that the nodes actually work. The scoped variables within each function should be talking to each other. For example, add a self. before each attribute so that the variables become class attributes instead.

Examples

Example compare and contrast between ROS2 (left) and ROS1 (right):
Image

Example code snippet where problem occurs:
Image

@Alb33rt Alb33rt added the bug Something isn't working label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant