Simplify example code #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @BlackHoleFox! My bad for the radio silence, I am on another job that has been taking more of my programming attention recently. |
|
Been there before, no problem here. Thanks for taking a look :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly tidies up the example to use more modern Rust, less type specifications, and then drops
clapas a direct dependency. The expected behavior from the example's CLI meant a whole CLI argument library was very over the top. Also its been broken since the update toclap 0.4. Runningcargo run --example simplewould attempt to rebind the server instead of connecting as a client. The replaced args parsing handles it right again:Closes #178