rasdaemon: add mc_event trigger #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winterddd
force-pushed
the
mc_trigger
branch
from
6e793cd to
82c451e
Compare
mchehab
requested changes
Jan 22, 2024
winterddd
force-pushed
the
mc_trigger
branch
3 times, most recently
from
a4c9676 to
93d2518
Compare
|
Hi, mchehab: I have changed the codes that you mentioned before, can you review them again and merge them? |
Allow users to run a trigger when RAS mc_event occurs, The mc_event
trigger is separated into CE trigger and UE trigger, this is because
CE is more frequent than UE, and the CE trigger will lead to more
performance hits. Users can choose different triggers for CE/UE to
reduce this effect.
Users can config trigger in /etc/sysconfig/rasdaemon:
TRIGGER_DIR: The trigger diretory
MC_CE_TRIGGER: The script executed when corrected error occurs.
MC_UE_TRIGGER: The script executed when uncorrected error occurs.
No script will be executed if MC_CE_TRIGGER/MC_UE_TRIGGER is null.
Signed-off-by: Ruidong Tian <[email protected]>
|
Hi, @mchehab, the requested changes is addressed, do you have any plan to merge this PR? Other user @PradipGaikwad also waits for this PR. Thank you. |
|
Merged, thanks! I did some cleanups and added support for memory failure events, as it helped me testing the feature on ARM QEMU emulation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to run a trigger when RAS mc_event occurs, The mc_event trigger is separated into CE trigger and UE trigger, this is because CE is more frequent than UE, and the CE trigger will lead to more performance hits. Users can choose different triggers for CE/UE to reduce this effect.
Users can config trigger in /etc/sysconfig/rasdaemon:
No script will be executed if MC_CE_TRIGGER/MC_UE_TRIGGER is null.