Fix for few compilation warnings and checkpatch errors. #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for following compilation warning,
ras-memory-failure-handler.c:120:6: warning: implicit declaration of function ‘asprintf’; did you mean ‘vsprintf’? [-Wimplicit-function-declaration]
if (asprintf(&env[ei++], "PATH=%s", getenv("PATH") ?: "/sbin:/usr/sbin:/bin:/usr/bin") < 0)
Signed-off-by: Shiju Jose <[email protected]>
Removed unused definition for RB_ROOT from rbtree.h Signed-off-by: Shiju Jose <[email protected]>
Fix following checkpatch error in ras-mce-handler.c Delete below obselte code under #if 0 ... #endif WARNING: Consider removing the code enclosed by this #if 0 and its #endif WARNING: Consider removing the code enclosed by this #if 0 and its #endif Signed-off-by: Shiju Jose <[email protected]>
Remove unused code enclosed under #if 0 to fix the checkpatch warnings. Signed-off-by: Shiju Jose <[email protected]>
… columns Fix following checkpatch warning in ras-arm-handler. + trace_seq_printf(s, " Program execution can be restarted reliably at the PC associated with the error"); Signed-off-by: Shiju Jose <[email protected]>
…not used Fix following compilation warning, ras-events.c:318:12: warning: ‘filter_ras_mc_event’ defined but not used [-Wunused-function] static int filter_ras_mc_event(struct ras_events *ras, char *group, char *event, Signed-off-by: Shiju Jose <[email protected]>
Fix following checkpatch warning, CHECK: spaces preferred around that '*' (ctx:WxV) + sqlite3_stmt *stmt_dec_record; Signed-off-by: Shiju Jose <[email protected]>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for few compilation warnings and checkpatch errors.