Skip to content

Commit

Permalink
[pre-commit.ci] auto fixes from pre-commit.com hooks
Browse files Browse the repository at this point in the history
for more information, see https://pre-commit.ci
  • Loading branch information
pre-commit-ci[bot] committed Oct 16, 2024
1 parent ee635d7 commit 22dca55
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 20 deletions.
29 changes: 11 additions & 18 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ ignore = [
"D401", # first-line should be in imperative mood
# D407 needs to be ignored as it otherwise messes up the formatting in our API docs
"D407", # missing dashed underline after section
"PD901", # allow using the generic variable name `df` for DataFrames
"PD901" # allow using the generic variable name `df` for DataFrames
]
select = [
"E", # pycodestyle errors
Expand All @@ -69,25 +69,12 @@ select = [
"C4", # flake8-comprehensions
"RUF", # Ruff-specific rules
"PL", # pylint
"PD", # pandas-vet
"UP", # pyupgrade
"PERF", # perflint
"FURB", # refurb
"PD", # pandas-vet
"UP", # pyupgrade
"PERF", # perflint
"FURB" # refurb
]


# TODO:
# trailing comma
# correct docstrings
# format code in docs
# think about pydantic to python

[tool.ruff.lint.pyupgrade]
# Don't do PEP 604 rewrites (e.g. Union[str, int] -> str | int), even in files that import
# `from __future__ import annotations`. This is needed since pydantic relies on the runtime behavior in Python 3.9.
# When we drop Python 3.9 we can remove this setting.
keep-runtime-typing = true

[tool.ruff.lint.per-file-ignores]
# Tests can use magic values, assertions, and relative imports, ignore missing docstrings,
# compare to empty string
Expand All @@ -100,3 +87,9 @@ convention = "google"

[tool.ruff.lint.pylint]
max-args = 6

[tool.ruff.lint.pyupgrade]
# Don't do PEP 604 rewrites (e.g. Union[str, int] -> str | int), even in files that import
# `from __future__ import annotations`. This is needed since pydantic relies on the runtime behavior in Python 3.9.
# When we drop Python 3.9 we can remove this setting.
keep-runtime-typing = true
2 changes: 0 additions & 2 deletions vizro-core/hatch.toml
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ pypath = "python -c 'import sys; print(sys.executable)'"
# Only run pre-commit hooks when schema is generated, not when it's checked. This keeps the check fast in CI.
schema = ["python schemas/generate.py", 'SKIP=gitleaks pre-commit run --files="schemas/$(hatch version).json" > /dev/null']
schema-check = ["python schemas/generate.py --check"]
# TODO: check codespaces

secrets = "pre-commit run gitleaks --all-files"
# Note `hatch run test` currently fails due to interference between integration tests and unit tests. Ideally we would
# fix this, but we don't actually use `hatch run test` anywhere right now.
Expand Down

0 comments on commit 22dca55

Please sign in to comment.