Skip to content

Commit

Permalink
Get logs fix (#215)
Browse files Browse the repository at this point in the history
  • Loading branch information
l0uden authored Dec 19, 2023
1 parent 599b0b6 commit 5fc8dff
Show file tree
Hide file tree
Showing 3 changed files with 70 additions and 2 deletions.
21 changes: 21 additions & 0 deletions .github/workflows/test-integration-vizro-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,27 @@ jobs:
steps:
- uses: actions/checkout@v4

# Pinned Chrome version because chromedriver v120 recognized as chrome-headless-shell instead of chrome
# https://github.com/plotly/dash/issues/2712
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=4665
# https://github.com/mckinsey/vizro/pull/215/
# If these are fixed then this whole step can be removed.
- name: Install Chrome and chromedriver
run: |
export chrome_version=119.0.6045.105
sudo apt-get update
sudo apt-get install libu2f-udev -y
wget "https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_$chrome_version-1_amd64.deb"
sudo apt-get install -y --allow-downgrades ./google-chrome-stable_$chrome_version-1_amd64.deb
rm google-chrome-stable_$chrome_version-1_amd64.deb
wget https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/$chrome_version/linux64/chromedriver-linux64.zip
unzip chromedriver-linux64.zip
cd chromedriver-linux64
sudo mv chromedriver /usr/bin/chromedriver
sudo chown root:root /usr/bin/chromedriver
sudo chmod +x /usr/bin/chromedriver
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
<!--
A new scriv changelog fragment.
Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Highlights ✨
- A bullet item for the Highlights ✨ category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Removed
- A bullet item for the Removed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Added
- A bullet item for the Added category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Changed
- A bullet item for the Changed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Deprecated
- A bullet item for the Deprecated category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Fixed
- A bullet item for the Fixed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Security
- A bullet item for the Security category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
3 changes: 1 addition & 2 deletions vizro-core/tests/integration/test_examples.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,4 @@ def dashboard(request, monkeypatch):
def test_dashboard(dash_duo, dashboard):
app = Vizro(assets_folder=Path(__file__).parents[2] / "examples/assets").build(dashboard).dash
dash_duo.start_server(app)
# TODO: resolve the problem with driver recognized as chrome-headless-shell instead of chrome
# assert dash_duo.get_logs() == []
assert dash_duo.get_logs() == []

0 comments on commit 5fc8dff

Please sign in to comment.