Skip to content

Commit

Permalink
Merge branch 'main' into docs/add_card_icon_styling_example
Browse files Browse the repository at this point in the history
  • Loading branch information
nadijagraca committed Apr 5, 2024
2 parents 35905ad + dcbe2dc commit ad7c6c9
Show file tree
Hide file tree
Showing 2 changed files with 55 additions and 2 deletions.
9 changes: 7 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,16 @@ repos:
additional_dependencies: ["bandit[toml]"]

- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.8.0
rev: v1.9.0
hooks:
- id: mypy
files: ^vizro-core/src/
additional_dependencies:
- pydantic>=1.10.13, <2 # deliberately pinned to <2 until we bump our pydantic requirement to strictly >=2
# Deliberately pinned to <2 until we bump our pydantic requirement to strictly >=2.
# pydantic>=1.10.15 includes this fix which flags some genuine type problems. These will take a while to fix
# or ignore so for now we just pin to 1.10.14 which doesn't flag the problems.
# https://github.com/pydantic/pydantic/pull/8765
- pydantic==1.10.14

- repo: https://github.com/gitleaks/gitleaks
rev: v8.18.2
Expand Down Expand Up @@ -121,3 +125,4 @@ ci:
- bandit
- mypy
- gitleaks
- vale
48 changes: 48 additions & 0 deletions vizro-core/changelog.d/20240405_103212_antony.milne_fix_mypy.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
<!--
A new scriv changelog fragment.
Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Highlights ✨
- A bullet item for the Highlights ✨ category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Removed
- A bullet item for the Removed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Added
- A bullet item for the Added category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Changed
- A bullet item for the Changed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Deprecated
- A bullet item for the Deprecated category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Fixed
- A bullet item for the Fixed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Security
- A bullet item for the Security category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->

0 comments on commit ad7c6c9

Please sign in to comment.