Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify PR template #227

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Simplify PR template #227

merged 1 commit into from
Dec 19, 2023

Conversation

antonymilne
Copy link
Contributor

@antonymilne antonymilne commented Dec 18, 2023

Description

This is an example of what the new template looks like!

I've removed the number of checkboxes that authors need to click:

  • removed the "Types of changes" section which should be done by Label instead
  • removed points that are no longer necessary from "Checklist" section
  • put the two remaining points under "Notice" so you only need to check one box

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

Copy link
Contributor

@petar-qb petar-qb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but interested why we decided to remove "Types of changes" section?

@antonymilne antonymilne merged commit 599b0b6 into main Dec 19, 2023
37 checks passed
@antonymilne antonymilne deleted the tidy/pr-template branch December 19, 2023 08:05
@huong-li-nguyen
Copy link
Contributor

Approved, but interested why we decided to remove "Types of changes" section?

The idea was to use the labels for the type of changes instead and simplify the template by having to check only one box :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants