[pre-commit.ci] pre-commit autoupdate #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pre-commit-ci[bot]](https://avatars.githubusercontent.com/in/68672?s=60&v=4){kind=small}
pre-commit-ci
bot
requested review from
Joseph-Perkins,
antonymilne,
huong-li-nguyen,
maxschulz-COL and
lingyielia
as code owners
huong-li-nguyen
force-pushed
the
pre-commit-ci-update-config
branch
from
a224e06 to
02cb9a7
Compare
Comment on lines
+71
to
+76
| # Ignore current false positives for pydantic models subclassing across files | ||
| # See: https://github.com/astral-sh/ruff/issues/5243#issuecomment-1860776975 | ||
| "**/models/**" = ["RUF012"] | ||
| # Tests can use magic values, assertions, and relative imports, ignore missing docstrings, | ||
| # compare to empty string | ||
| "**/tests/**" = ["PLR2004", "S101", "TID252", "D100", "D101", "D102", "D103", "PLC1901"] | ||
| "**/tests/**" = ["PLR2004", "S101", "TID252", "D100", "D101", "D102", "D103", "PLC1901", "RUF012"] |
There was a problem hiding this comment.
Be aware of this ignores and check the issue comment to understand why it's ok to ignore for now. Ruff might fix this in the future (given that they already ignore this error for subclasses within the same file), so we can eventually remove it later.
huong-li-nguyen
approved these changes
Jan 2, 2024
huong-li-nguyen
force-pushed
the
pre-commit-ci-update-config
branch
from
bde9e0d to
ee15b0d
Compare
maxschulz-COL
approved these changes
Jan 3, 2024
updates: - [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.4.0...v4.5.0) - [github.com/pre-commit/mirrors-prettier: v3.0.0-alpha.9-for-vscode → v4.0.0-alpha.8](pre-commit/mirrors-prettier@v3.0.0-alpha.9-for-vscode...v4.0.0-alpha.8) - [github.com/macisamuele/language-formatters-pre-commit-hooks: d2425a6 → v2.12.0](macisamuele/language-formatters-pre-commit-hooks@d2425a6...v2.12.0) - https://github.com/charliermarsh/ruff-pre-commit → https://github.com/astral-sh/ruff-pre-commit - [github.com/astral-sh/ruff-pre-commit: v0.0.261 → v0.1.9](astral-sh/ruff-pre-commit@v0.0.261...v0.1.9) - [github.com/psf/black: 23.3.0 → 23.12.1](psf/black@23.3.0...23.12.1) - [github.com/PyCQA/bandit: 1.7.5 → 1.7.6](PyCQA/bandit@1.7.5...1.7.6) - [github.com/pre-commit/mirrors-mypy: v1.2.0 → v1.8.0](pre-commit/mirrors-mypy@v1.2.0...v1.8.0) - [github.com/gitleaks/gitleaks: v8.16.4 → v8.18.1](gitleaks/gitleaks@v8.16.4...v8.18.1)
for more information, see https://pre-commit.ci
huong-li-nguyen
force-pushed
the
pre-commit-ci-update-config
branch
from
ee15b0d to
7489cc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates: