-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable automatic logo
insertion
#248
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 811bc1f.
for more information, see https://pre-commit.ci
This reverts commit 811bc1f.
for more information, see https://pre-commit.ci
…insey/vizro into dev/dashboard_title_position
huong-li-nguyen
force-pushed
the
feat/enable_logo
branch
from
January 4, 2024 16:06
4b37b93
to
5503f7e
Compare
1 task
…into feat/enable_logo
for more information, see https://pre-commit.ci
huong-li-nguyen
requested review from
Joseph-Perkins,
antonymilne,
maxschulz-COL and
Anna-Xiong
as code owners
January 16, 2024 13:37
nadijagraca
reviewed
Jan 16, 2024
nadijagraca
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I just have one small comment on css.
antonymilne
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌟 Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
logo
insertion into thepage-header
container - this means that the first file found calledlogo. xxx
in the assets folder will be positioned in the left cornersettings
container will now move to theright-header
container if bothdashboard-title
andlogo
are hidden@nadijagraca - thanks for creating the first POC on this! I've had to update it based on the new container structure and logic we will likely introduce here. Depending on your capacity you could help me finish this PR off with docs and tests :)
TO DO in separate PRs:
Screenshot
Logo ⛔ + Dashboard Title ✅
Logo ✅ + Dashboard Title ✅
Logo ✅ + Dashboard Title ⛔
Logo ⛔ + Dashboard Title ⛔
Rectangular Logo ✅ + Dashboard Title ⛔
See this commit to see the relevant CSS changes: d71f101
Notice
I acknowledge and agree that by checking this box and clicking "Submit Pull Request,":