Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#397 bumped our pre-commit mypy from 1.8.0 to 1.9.0, which seemed to flag new errors that were still there even after reversion to 0.18.0 in #403.
The reason for these new errors was not actually the change to mypy version but that there was a new pydantic release at about the same time. Pinning the pydantic version used by mypy fixes this.
There is no caching in our CI. There is caching on pre-commit.ci but it works well and will always be running the correct version specified in our .pre-commit-config.yaml. So both our CI and pre-commit.ci are still perfect sources of truth and working correctly. Behaviour locally should be the identical to these, but just in case it's not then
pre-commit clean
should fix it by clearing your local cache.Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":