Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Move tests from CircleCI to GitHub #558

Merged
merged 40 commits into from
Aug 2, 2024
Merged

[CI] Move tests from CircleCI to GitHub #558

merged 40 commits into from
Aug 2, 2024

Conversation

l0uden
Copy link
Contributor

@l0uden l0uden commented Jul 1, 2024

Description

Deleted .github/workflows/circleci-trigger.yml
Added:
.github/workflows/vizro-qa-notebooks-tests-trigger.yml - for triggering notebooks tests in vizro qa repo .github/workflows/vizro-qa-tests-trigger.yml - for triggering integration and screenshot tests in vizro qa repo

Connected with https://github.com/mckinsey/vizro-qa/pull/101

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@l0uden l0uden temporarily deployed to circleci_secrets July 1, 2024 14:57 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to circleci_secrets July 2, 2024 13:15 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to vizro_secrets July 2, 2024 13:15 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to vizro_secrets July 2, 2024 13:16 Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to circleci_secrets July 2, 2024 13:16 Inactive
l0uden added 2 commits July 2, 2024 15:18
…i_to_github

# Conflicts:
#	.github/workflows/vizro-qa-trigger.yml
@l0uden l0uden temporarily deployed to vizro_secrets July 2, 2024 13:19 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to circleci_secrets July 2, 2024 13:19 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to circleci_secrets July 2, 2024 13:20 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to vizro_secrets July 2, 2024 13:20 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to vizro_secrets July 2, 2024 13:21 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to circleci_secrets July 2, 2024 13:21 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to circleci_secrets July 2, 2024 13:23 Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to vizro_secrets July 2, 2024 13:23 Inactive
@l0uden l0uden temporarily deployed to circleci_secrets July 2, 2024 13:23 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to vizro_secrets July 2, 2024 13:23 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to circleci_secrets July 2, 2024 13:25 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to vizro_secrets July 2, 2024 13:25 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to circleci_secrets July 2, 2024 16:14 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to vizro_secrets July 19, 2024 10:25 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to vizro_secrets July 19, 2024 10:25 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to vizro_secrets July 19, 2024 10:27 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to vizro_secrets July 19, 2024 10:27 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to vizro_secrets July 19, 2024 12:02 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to vizro_secrets July 19, 2024 12:02 — with GitHub Actions Inactive
tools/yaml_check.py Outdated Show resolved Hide resolved
tools/yaml_check.py Outdated Show resolved Hide resolved
tools/yaml_check.py Outdated Show resolved Hide resolved
.github/workflows/checks-workflows.yml Outdated Show resolved Hide resolved
.github/workflows/checks-workflows.yml Outdated Show resolved Hide resolved
.github/workflows/vizro-qa-tests-trigger.yml Outdated Show resolved Hide resolved
.github/workflows/vizro-qa-tests-trigger.yml Outdated Show resolved Hide resolved
.github/workflows/vizro-qa-tests-trigger.yml Outdated Show resolved Hide resolved
.github/workflows/vizro-qa-notebooks-tests-trigger.yml Outdated Show resolved Hide resolved
.github/workflows/test-integration-vizro-ai.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for making the changes and figuring out the matrix thing! ⭐

Just a few very minor comments but feel free to merge whenever you're ready.

.github/workflows/checks-workflows.yml Outdated Show resolved Hide resolved
tools/scan_yaml_for_risky_text.py.py Outdated Show resolved Hide resolved
tools/scan_yaml_for_risky_text.py.py Outdated Show resolved Hide resolved
.github/workflows/vizro-qa-tests-trigger.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job you guys! @l0uden @antonymilne

I have a couple of questions to the outcome itself. Feel free to merge though if not relevant for this PR:

1. I think we can remove the CircleCI test trigger as a required test in this PR now, right?
Screenshot 2024-07-30 at 12 57 15

2. Instead of {{matrix.label}} - shouldn't there be a python version or whatever we have reserved for matrix.label? What is it for?
Screenshot 2024-07-30 at 12 54 58

3. Just to clarify - do I understand correctly that Vizro QA notebooks tests trigger run the notebook test in our QA repo? And the Vizro QA integration tests trigger run the screenshot tests in our QA repo?

If yes, is there a way how we can actually add a link to the error message on where to find the failing screenshots tests? 😬 It doesn't have to be part of this PR, but I always have difficulties finding which run has failed in the QA repo and where I can find the failing screenshot tests since it doesn't run directly from here anymore.

Screenshot 2024-07-30 at 12 56 03

Like somewhere here - adding a link to the the location of the failing screenshot tests or to the connected run on CircleCI?
Screenshot 2024-07-30 at 13 03 33

.github/workflows/checks-workflows.yml Show resolved Hide resolved
@huong-li-nguyen huong-li-nguyen self-requested a review July 30, 2024 11:14
@l0uden
Copy link
Contributor Author

l0uden commented Jul 30, 2024

Amazing job you guys! @l0uden @antonymilne

I have a couple of questions to the outcome itself. Feel free to merge though if not relevant for this PR:

1. I think we can remove the CircleCI test trigger as a required test in this PR now, right? Screenshot 2024-07-30 at 12 57 15

2. Instead of {{matrix.label}} - shouldn't there be a python version or whatever we have reserved for matrix.label? What is it for? Screenshot 2024-07-30 at 12 54 58

3. Just to clarify - do I understand correctly that Vizro QA notebooks tests trigger run the notebook test in our QA repo? And the Vizro QA integration tests trigger run the screenshot tests in our QA repo?

If yes, is there a way how we can actually add a link to the error message on where to find the failing screenshots tests? 😬 It doesn't have to be part of this PR, but I always have difficulties finding which run has failed in the QA repo and where I can find the failing screenshot tests since it doesn't run directly from here anymore.

Screenshot 2024-07-30 at 12 56 03

Like somewhere here - adding a link to the the location of the failing screenshot tests or to the connected run on CircleCI? Screenshot 2024-07-30 at 13 03 33

Thanks @huong-li-nguyen !

**1. Sure. I will do it after the merge

**2. When we're skipping tests the values from matrix can't be read. You can see the same picture for vizro-ai integration tests

**3. There's a chat with detailed information about all failing builds with links. I will add everyone to it after merging the PR

@l0uden l0uden merged commit b445dee into main Aug 2, 2024
31 checks passed
@l0uden l0uden deleted the circleci_to_github branch August 2, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants