-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Move tests from CircleCI to GitHub #558
Conversation
for more information, see https://pre-commit.ci
…i_to_github # Conflicts: # .github/workflows/vizro-qa-trigger.yml
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for making the changes and figuring out the matrix thing! ⭐
Just a few very minor comments but feel free to merge whenever you're ready.
…i_to_github � Conflicts: � .github/workflows/circleci-trigger.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job you guys! @l0uden @antonymilne
I have a couple of questions to the outcome itself. Feel free to merge though if not relevant for this PR:
1. I think we can remove the CircleCI test trigger as a required test in this PR now, right?
2. Instead of {{matrix.label}} - shouldn't there be a python version or whatever we have reserved for matrix.label? What is it for?
3. Just to clarify - do I understand correctly that Vizro QA notebooks tests trigger run the notebook test in our QA repo? And the Vizro QA integration tests trigger run the screenshot tests in our QA repo?
If yes, is there a way how we can actually add a link to the error message on where to find the failing screenshots tests? 😬 It doesn't have to be part of this PR, but I always have difficulties finding which run has failed in the QA repo and where I can find the failing screenshot tests since it doesn't run directly from here anymore.
Like somewhere here - adding a link to the the location of the failing screenshot tests or to the connected run on CircleCI?
Thanks @huong-li-nguyen ! **1. Sure. I will do it after the merge **2. When we're skipping tests the values from matrix can't be read. You can see the same picture for vizro-ai integration tests **3. There's a chat with detailed information about all failing builds with links. I will add everyone to it after merging the PR |
Description
Deleted
.github/workflows/circleci-trigger.yml
Added:
.github/workflows/vizro-qa-notebooks-tests-trigger.yml
- for triggering notebooks tests in vizro qa repo.github/workflows/vizro-qa-tests-trigger.yml
- for triggering integration and screenshot tests in vizro qa repoConnected with https://github.com/mckinsey/vizro-qa/pull/101
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":