Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] Vizro-ai base dashboard tests #607

Merged
merged 188 commits into from
Aug 19, 2024
Merged

[QA] Vizro-ai base dashboard tests #607

merged 188 commits into from
Aug 19, 2024

Conversation

l0uden
Copy link
Contributor

@l0uden l0uden commented Jul 31, 2024 •
edited
Loading

Description

Added very simple check for the dashboard creation

Changed upper bound for urllib3 because of this error: https://bugs.launchpad.net/python-jenkins/+bug/2018567

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

lingyielia and others added 30 commits May 28, 2024 23:14
@lingyielia
pure data summary on multi datasets
3fddb9c
@lingyielia
remove nested func
75cd1f2
@lingyielia
add in pydantic spike
5790ebc
@lingyielia
remove graph creation
7a6e47d
@lingyielia
cleanup
a80955a
@lingyielia
cleanup
85d683c
@lingyielia
relocate core builder
4e8ef07
@lingyielia
full string generation
7895afa
@lingyielia
data manager init
391fe6c
@lingyielia
work with aggrid one dataframe
26f967c
@lingyielia
remove data manager
57b7757
@lingyielia
multi dataframe
d3dd078
@lingyielia
clean up
9896efb
@lingyielia
merge
3db523e
@lingyielia
unify pydantic import
088b858
@lingyielia
unify structured output usage
2b1c8af
@lingyielia
consolidate nodes
f4d8562
@lingyielia
dummy filter
41260d5
@lingyielia
rename data sample
1541d05
@lingyielia
make state a pydantic
a6b950b
@lingyielia
add layout placeholder
bee0be8
@lingyielia
make methods private
38fd0b8
@lingyielia
add some initial fallbacks
f3df206
@lingyielia
clean up
6ed0d01
@lingyielia
example notebook
35e1c15
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
e2e03cf 
for more information, see https://pre-commit.ci
@lingyielia
decouple plan and build
9f4eda1
@lingyielia
linting
bc5e501
@lingyielia
merge
e60d488
@lingyielia
linting
714d851
l0uden and others added 24 commits August 5, 2024 15:24
@l0uden
no slack
56a0b03
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
55ee93d 
for more information, see https://pre-commit.ci
@l0uden
start dashboard
8e7ea68
@l0uden
Merge branch 'main' of https://github.com/mckinsey/vizro into qa/vizr…
a224512 
…o_ai_dashboard_tests
@l0uden
chromedriver option
3d00d7b
@l0uden
linting
e739d59
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7099e8d 
for more information, see https://pre-commit.ci
@nadijagraca @l0uden
[Docs] Update example for advanced charts with Vizro-AI (#611)
41e7061
@l0uden
enable tests run on PR
ee228e6
@l0uden
Merge branch 'main' of https://github.com/mckinsey/vizro into qa/vizr…
bef31b9 
…o_ai_dashboard_tests
@l0uden
chromedriver to hatch
2dd7568
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
2279136 
for more information, see https://pre-commit.ci
@l0uden
test latest selenium
221b46a
@l0uden
dash_duo
9c49c90
@l0uden
urllib3==1.26.19
b2e7a74
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
8226e41 
for more information, see https://pre-commit.ci
@l0uden
urllib3 fix
d74c915
@l0uden
Merge branch 'qa/vizro_ai_dashboard_tests' of https://github.com/mcki…
055ba17 
…nsey/vizro into qa/vizro_ai_dashboard_tests

� Conflicts:
�	vizro-ai/pyproject.toml
@l0uden
Merge branch 'main' of https://github.com/mckinsey/vizro into qa/vizr…
a75b305 
…o_ai_dashboard_tests
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
ae0160d 
for more information, see https://pre-commit.ci
@l0uden
linting
0853d01
@l0uden
Merge branch 'qa/vizro_ai_dashboard_tests' of https://github.com/mcki…
4406edd 
…nsey/vizro into qa/vizro_ai_dashboard_tests
@l0uden
linting
932b1f0
@l0uden
uncomment slack notification
ad71da4
@l0uden l0uden marked this pull request as ready for review August 16, 2024 13:34
maxschulz-COL
maxschulz-COL approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! My only feedback is that I would have made it even easier. But we can create our "matrix of complexities" in later PRs!

@lingyielia
Copy link
Contributor

Amazing! My only feedback is that I would have made it even easier. But we can create our "matrix of complexities" in later PRs!

Agreed. For this entry point test, it would be considered passed as long as a dashboard is up and running, with minimum requirements.

lingyielia
lingyielia approved these changes Aug 17, 2024
View reviewed changes
Copy link
Contributor

@lingyielia lingyielia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@l0uden l0uden merged commit 221bd71 into main Aug 19, 2024
39 checks passed
@l0uden l0uden deleted the qa/vizro_ai_dashboard_tests branch August 19, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxschulz-COL maxschulz-COL maxschulz-COL approved these changes

@lingyielia lingyielia lingyielia approved these changes

@Joseph-Perkins Joseph-Perkins Awaiting requested review from Joseph-Perkins Joseph-Perkins is a code owner

@Anna-Xiong Anna-Xiong Awaiting requested review from Anna-Xiong

@antonymilne antonymilne Awaiting requested review from antonymilne antonymilne is a code owner

@huong-li-nguyen huong-li-nguyen Awaiting requested review from huong-li-nguyen huong-li-nguyen is a code owner

Assignees
No one assigned
Labels
Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@l0uden @lingyielia @maxschulz-COL @nadijagraca