Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tidy] Make vale pre-commit hook run in verbose mode #730

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

antonymilne
Copy link
Contributor

Description

Currently we don't see vale suggestions/warnings unless an error is also raised. This PR changes that so that suggestions and warnings are shown even when no error is raised. The linting job will still pass even with these suggestions and warnings shown, but we'll be more aware of them now.

@stichbury I've tried this locally but would be great if you could try also just so it works as you'd like. Just run hatch run lint as per normal and you should see the suggestions and warnings even when there's no errors.

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

Copy link
Contributor

@huong-li-nguyen huong-li-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly 👍 🚀

Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and it's good incentive to get those suggestions and warnings "fixed"

@antonymilne antonymilne enabled auto-merge (squash) September 23, 2024 10:47
@antonymilne antonymilne merged commit 8471f01 into main Sep 23, 2024
32 checks passed
@antonymilne antonymilne deleted the tidy/make-vale-verbose branch September 23, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants