-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tidy] Remove pip as dependency and fully switch to uv #738
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Cool stuff! For me the GUi installation did not work after remove the homebrew one, but after reverting to homebrew, all is good with my initial setup :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
How to review
The only files that have changed in an interesting way are github workflows, pyproject.toml and hatch.toml files. The rest is just minor linting stuff mainly from fixing isort so you can just ignore.
Description
Some tidying in preparation for updating the contribution guidelines (will follow in a separate PR). There's no user-facing changes. Major developer-facing changes are:
pip
has been removed as a dependency from all environments asuv
is basically better in every way for our needsMinor developer-facing changes are:
lint
no longer has its own environment.hatch run lint
still works the same as before, but now you can do e.g.hatch run lint mypy
againWhat should I do as a developer?
All this will be made clear in the contributors guide, but in brief:
hatch
hatch self update
hatch self
doesn't yet exist so can do it by upgrading withbrew
orpipx
or whatever you used to installhatch
in the first place. After that, any future upgrades you can do withhatch self update
hatch
and reinstall from scratch (this is what I did. There's a GUI to do this now and it's super easy and just takes a couple of seconds)pip
while you're developing vizro. If you need pip-like functionality within vizro then instead dohatch run pip
, e.g.pip install x
becomeshatch run pip install x
. This will run uv under the hood (no need to install uv though). Usingpip
withouthatch run
will not work welluv
across your whole computer - no need to interact withpip
ever again! If you need pip-like functionality then useuv pip
instead (you can make an alias to do this). If you need a virtual environment then useuv venv
. If you need tools then useuvx
. Life will be good, I promise!Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":