-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Demo] Add diverging bar to visual-vocabulary #792
Conversation
Hi @hxe00570, thank you for contributing. 🙌 There are several things that need to be added to this PR for it to be merged.
Also, you could try check and fix the 3 failed CI?
Can you please advise if you wish to continue working on this issue, or some other contributor can take it from here? Thank you, 🙏 |
Thank you, I think I corrected this. Please inform |
Can you please push your latest changes as I cannot see new commits. Thank you, |
I have tried a few times to push and I keep getting different errors (this is my first contribution so I’m sure it’s user error). I have been using the Codespace. Any chance yall are on site at GHC and someone might be willing to meet up and help me? |
Hello @hxe00570 , I just looked at the chart you created in this PR: #795 and it looks beautiful! ⭐ I also noticed that you tackled the more challenging task of creating a diverging stacked bar chart! 🚀 If you find yourself short on time or encountering issues with the development setup, we're happy to help you wrap this up within your branch. This way, you'll still receive credit for the contribution, and we can handle any remaining technical details. Please let me know if you'd prefer to complete this on your own or if you'd like us to assist in finishing it up within your branch :) |
@huong-li-nguyen thank you! Yes, that is totally fine with me! I'd like to volunteer to attempt some others too if that is available. Thanks! H |
@nadijagraca @huong-li-nguyen Had a quick chat with @hxe00570 today and she is ready to handover the pr to Vizro team now. I will close this PR (#792) and we can assist in finishing it up in PR #795. 🙌 |
Reopening this PR because @hxe00570 actually worked on the diverging stacked bar chart, so I'll use the two PRs to finish off 2 charts: the diverging bar chart and diverging stacked bar chart :) |
@hxe00570 - I really liked your pastry example, so I've kept the data but I just replaced the measure with the profit ratio (fits better with negative and positive values) :) You tackled the more complex chart which is the diverging stacked bar chart - so don't worry I'll re-use the code you created in another PR: #795 For the diverging bar chart, we were actually just looking for a simple sorted bar chart. So, in this PR, I am simplifying the function call by using the pure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all your work on this @hxe00570! 🙏
@huong-li-nguyen I think there's something small we should change here - see comment. But otherwise looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The chart looks great, well done @hxe00570 and @huong-li-nguyen . 🚀
Description
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":