Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After quite a bit of discussion and testing, I have decided we are good to remove gitleaks after all. Currently we have GitHub advanced security and Gitguardian working. Gitguardian might be switched off because GitHub advanced security seems to be a superset of its features (e.g. it will even stop you putting credentials in an edit done directly in the GitHub UI).
The reason that test credentials didn't get detected by these tools before is because their threshold for what constitutes a real risky credential is higher than gitleaks. e.g. they only care about AWS keys and IDs if they are provided together, they check that the length and format of these is real to avoid flagging false positives, etc. All the security people at the Firm seem happy that these tools are sensitive enough and that they are working correctly, so I'm proceeding with the tidy up and removing it.
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":