-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Demo] Add sparkline to ViViVo #875
Conversation
for more information, see https://pre-commit.ci
View the example dashboards of the current commit live on PyCafe ☕ 🚀Updated on: 2024-11-19 09:06:25 UTC Link: vizro-core/examples/dev/ Link: vizro-core/examples/scratch_dev |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, although actually I found having three charts with facet_row
kind of confusing:
- are they the same y-axis scale?
- are they on a shared y axis or separate? Like without any context I think from glancing at the graph you could easily misunderstand the plot to be showing that Google stock is always above Amazon which is above Apple
So tbh I'm not sure how "best practice" this is. Maybe we should just show one stock instead of comparing three? Or maybe separate the graphs horizontally with a thin grey line?
No strong feelings though, so if this is commonly how sparklines are done then that's ok.
Typically, sparklines display multiple traces, so having just a single trace wouldn't be effective in this context. It's not necessary for them to share the same y-axis scale, but they should use the same unit. The focus is less on comparing their magnitudes and more on observing the overall trend across all traces simultaneously. I like your idea of adding more separation though, I've now added grey lines to better distinguish between them. 👍 |
for more information, see https://pre-commit.ci
Description
Based on #793 - thank you again ataraexia! ⭐
px.line
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":