Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bot] pre-commit autoupdate #912

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Dec 2, 2024

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.7.2 → v0.8.1](astral-sh/ruff-pre-commit@v0.7.2...v0.8.1)
- [github.com/PyCQA/bandit: 1.7.10 → 1.8.0](PyCQA/bandit@1.7.10...1.8.0)
- [github.com/pre-commit/mirrors-mypy: v1.10.1 → v1.13.0](pre-commit/mirrors-mypy@v1.10.1...v1.13.0)
- [github.com/errata-ai/vale: v3.8.0 → v3.9.1](errata-ai/vale@v3.8.0...v3.9.1)
@github-actions github-actions bot added the Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package label Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2024-12-03 09:55:34 UTC
Commit: ee20084

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

@huong-li-nguyen
Copy link
Contributor

@stichbury - I did minor docs changes based on the latest vale errors/suggestions - could you take a look? 🙏

@huong-li-nguyen huong-li-nguyen self-assigned this Dec 3, 2024
@huong-li-nguyen huong-li-nguyen changed the title [pre-commit.ci] pre-commit autoupdate [Bot] pre-commit autoupdate Dec 3, 2024
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks for doing that.

We are going to remove Vale from linting when mdformat joins the pack because they don't play nicely together. The changes made by mdformat to remove blank lines mean that Vale now checks admonitions, and where code is found in an admonition, Vale doesn't recognise it as such and gets in a tizzy.

Vale will continue to exist in the repo to run independently on PRs when we remember, so it's great to make this change now, but in future it won't be forced on you.

@huong-li-nguyen huong-li-nguyen merged commit d10ccdb into main Dec 3, 2024
38 checks passed
@huong-li-nguyen huong-li-nguyen deleted the pre-commit-ci-update-config branch December 3, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants