Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Increase dash lower bound from 2.17.1 to 2.18.0 #918

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

petar-qb
Copy link
Contributor

@petar-qb petar-qb commented Dec 4, 2024

Description

Increased as we use dcc.Loading.id for targeting dynamic filters, but this is enabled in https://github.com/plotly/dash/releases/tag/v2.18.0.

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2024-12-04 10:28:11 UTC
Commit: 59ab414

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

@huong-li-nguyen huong-li-nguyen changed the title [Deps] Increase dash lower bound from 2.17.1 to 2.18.0 [Dev] Increase dash lower bound from 2.17.1 to 2.18.0 Dec 4, 2024
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but should our lower-bound unit tests have been passing before if we hadn't bumped this previously?

@petar-qb
Copy link
Contributor Author

petar-qb commented Dec 4, 2024

Looks good, but should our lower-bound unit tests have been passing before if we hadn't bumped this previously?

I think this fix plotly/dash#2878 (which is the reason why I increased the dash version), only affects the UI tests, as it enabled the id to be visible in the DOM. And, as our UI tests for the dynamic filters are still implementing, we didn't notice any errors.

@petar-qb petar-qb merged commit 4e0ddb6 into main Dec 4, 2024
36 checks passed
@petar-qb petar-qb deleted the deps/dash_lower_bound_to_2.18.0 branch December 4, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants