Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(github): 🔧 ci cd for checking code style #26

Merged

Conversation

jagadhis
Copy link
Contributor

@jagadhis jagadhis commented Oct 4, 2024

Hi @mcnaveen would like you to review this pr

Changes done:

  1. moved from husky and prettier to lefthook and Stylistic eslint
  2. added ci/cd pipeline to check for linting when PR is raised

as i have removed some of the dependencies the reason for that is stylistic plugin will by default handle some of the rules if there is any rule we need to add we can further add to the eslintrc file


Resolves #14

Copy link

vercel bot commented Oct 4, 2024

@jagadhis is attempting to deploy a commit to the MC Naveen's projects Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2024

CLA assistant check
All committers have signed the CLA.

@jagadhis jagadhis changed the title Chore/issue 14 ci cd for checking code style chore(#issue14)-ci cd for checking code style Oct 4, 2024
@jagadhis jagadhis changed the title chore(#issue14)-ci cd for checking code style chore(github): 🔧 ci cd for checking code style Oct 4, 2024
@jagadhis jagadhis force-pushed the chore/issue-14-ci-cd-for-checking-code-style branch from 6e7eaf4 to f5f664c Compare October 4, 2024 10:34
@jagadhis jagadhis force-pushed the chore/issue-14-ci-cd-for-checking-code-style branch from 1e9c7ff to 9c31a28 Compare October 4, 2024 11:02
@mcnaveen
Copy link
Owner

mcnaveen commented Oct 4, 2024

Hi @jagadhis Thanks for the PR.
Can you check the action logs for on-pull-request. I see a bunch of errors.

Example:

1:1  Error: Definition for rule '@stylistic/indent' was not found.  @stylistic/indent
1:1  Error: Definition for rule '@stylistic/quotes' was not found.  @stylistic/quotes
1:1  Error: Definition for rule '@stylistic/object-curly-spacing' was not found.  @stylistic/object-curly-spacing
1:1  Error: Definition for rule '@stylistic/jsx-tag-spacing' was not found.  @stylistic/jsx-tag-spacing

@jagadhis
Copy link
Contributor Author

jagadhis commented Oct 4, 2024

@mcnaveen can you authorize and try it now ?

@jagadhis
Copy link
Contributor Author

jagadhis commented Oct 4, 2024

@mcnaveen i saw the errors it is typescript i will try to resolve it

@mcnaveen
Copy link
Owner

mcnaveen commented Oct 4, 2024

Okay. I know what is causing these errors now. Maybe #13 will fix these.

@jagadhis
Copy link
Contributor Author

jagadhis commented Oct 4, 2024

@mcnaveen yeah i should have tackled that first i will fix this first and will try to take on #13 since it is big change

@mcnaveen
Copy link
Owner

mcnaveen commented Oct 4, 2024

Yeah. It's bigger. I planned to work on this today. Once done. I'll have more core features lined up.

@jagadhis
Copy link
Contributor Author

jagadhis commented Oct 4, 2024

@mcnaveen this will work i checked in local there was no eslint errors for now i have disabled the rules once we fix issue #13 we can enable it again

@mcnaveen
Copy link
Owner

mcnaveen commented Oct 4, 2024

Awesome, Thanks for your awesome work.
I'm going to merge this now. Do you have a hacktoberfest profile setup already?
https://hacktoberfest.com/

@jagadhis
Copy link
Contributor Author

jagadhis commented Oct 4, 2024

@mcnaveen nope doing it now

@mcnaveen mcnaveen merged commit 1fb8365 into mcnaveen:dev Oct 4, 2024
3 of 4 checks passed
@jagadhis
Copy link
Contributor Author

jagadhis commented Oct 4, 2024

@mcnaveen i have setup my profile on hacktoberfest thanks for letting me know beofre merging

@mcnaveen
Copy link
Owner

mcnaveen commented Oct 4, 2024

Awesome. Thank you so much for your contribution. 🫡
You'll be added to contributor-only discord channel.

@jagadhis jagadhis deleted the chore/issue-14-ci-cd-for-checking-code-style branch October 4, 2024 18:54
@mcnaveen
Copy link
Owner

@all-contributors please add @jagadhis for code, ideas

Copy link
Contributor

@mcnaveen

I've put up a pull request to add @jagadhis! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI/CD for checking prettier/lint
3 participants