Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use unsigned int so that 0xFFFFFFFF can be stored #32

Open
wants to merge 1 commit into
base: 7.x
Choose a base branch
from

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Dec 3, 2021

Cherry-picked from #28

  • It fixes a bug where 0xFFFFFFFF was being narrowed down to int, which resulted in an error in the Clang compiler. This was fixed by adding unsigned int to the enums:
C:/opennurbs/opennurbs_defines.cpp:2032:8: error: case value evaluates to -1, which cannot be narrowed to type 'unsigned int' [-Wc++11-narrowing]
  case os_all_snaps:     osm = os_all_snaps; break;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant