Skip to content

Commit

Permalink
dnfdaemon: Correct argument direction in interface definition of Goal…
Browse files Browse the repository at this point in the history
…::cancel method

Both the arguments are output arguments, to be read by client, not
to be set by the client, thus mark them as such.

Related to rpm-software-management#1665 (comment)
  • Loading branch information
mcrha committed Sep 6, 2024
1 parent 7133b74 commit e0f7b91
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions dnf5daemon-server/dbus/interfaces/org.rpm.dnf.v0.Goal.xml
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ along with libdnf. If not, see <https://www.gnu.org/licenses/>.
Cancel the transaction that was initiated by `do_transaction()`. The transaction can only be canceled during the package download phase. Once the RPM transaction has begun, cancellation is no longer permitted.
-->
<method name="cancel">
<arg name="success" type="b" />
<arg name="error_msg" type="s" />
<arg name="success" type="b" direction="out" />
<arg name="error_msg" type="s" direction="out" />
</method>

</interface>
Expand Down

0 comments on commit e0f7b91

Please sign in to comment.