sim: Enable oversized_secondary_slot test with max-align-32 #2285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test case oversized_secondary_slot, introduced by PR !1286 was not enabled when the 'max-align-32' feature was selected because of the test case was failing with some configurations. Since 88294be, the oversized_secondary_slot test is now passing with 'max-align-32' in all configurations and can therefore be enabled. Signed-off-by: Thomas Altenbach <[email protected]>
de-nordic
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case
oversized_secondary_slot, introduced by #1286 was not enabled when themax-align-32feature was selected because the test case was failing with some configurations.From the PR description:
Since 88294be, the
oversized_secondary_slottest is now passing withmax-align-32in all configurations and can therefore be enabled.