Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP organizing things into classes #10

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mkulik-rh
Copy link
Collaborator

Description:
WIP

@mcurlej
Copy link
Owner

mcurlej commented May 31, 2022

Ok so this needs to be split into several PRs. There are too many changes at once to keep track of.

@mcurlej
Copy link
Owner

mcurlej commented May 31, 2022

The builders directory was meant to hold also other builders not only the mock one. The mock directory now holds not only stuff with regards to mock itself but also a lot of code which is related to the builder itself. The naming of mock/info sounds like it would contain only code which represents read only functionality, but it does not.

@mcurlej
Copy link
Owner

mcurlej commented May 31, 2022

Also we need to separate the multi-process code in its own PR after the reorganization is finished.

@mkulik-rh
Copy link
Collaborator Author

I separated multi-process to #11. It needed few compromises but end result is the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants