ODK update and stronger QC #224
Conversation
|
If my understanding is correct, I should be able to merge this with main now, right? |
|
Now, QC is activated. Basically you need to fix all the QC errors thrown up on this branch here, (you can test locally by running Let me know if you need any help! This will also take care of #222 |
|
Dont forget this @dillerm |
|
Getting ready to merge this, but have a quick question about the purpose of the profile.txt file. It lists a bunch of errors/warnings that don't seem to apply to OMRSE so just want to verify that this isn't documenting issues with the ontology. |
No this is purely about the tests the ODK will execute! Remember to not merge this before the tests pass, so merge master into this branch and see if all is ok! |
|
Thanks Nico! We will merge main into this branch first, before resolving
the pull request.
…On Fri, Mar 1, 2024 at 10:00 AM Nico Matentzoglu ***@***.***> wrote:
Getting ready to merge this, but have a quick question about the purpose
of the profile.txt file. It lists a bunch of errors/warnings that don't
seem to apply to OMRSE so just want to verify that this isn't documenting
issues with the ontology.
No this is purely about the tests the ODK will execute! Remember to not
merge this before the tests pass, so merge master into this branch and see
if all is ok!
—
Reply to this email directly, view it on GitHub
<#224 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJR55TNELA2SZ73WQAZ25TYWCQ3NAVCNFSM6AAAAABBLW22MOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZTGQ2DMNBVGQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Still one deprected_class_reference error to fix. Not ready to merge. We will need to make that fix (and propagate it to main if we don't do it there directly) and then merge main in again to test. |
|
Ok I made the fix, and now all checks have passed. This looks ok to merge. |
|
@matentzn the "Deploy Docs" qc failed, so I just wanted to ask if there was anything that we overlooked or if this is expected. |
mainbranch!