Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed qc errors caused by obsolete class equivalent class assertions … #225

Closed
wants to merge 1 commit into from

Conversation

dillerm
Copy link
Collaborator

@dillerm dillerm commented Jan 7, 2024

…and subclassof assertions that referenced anonymous resources, and re-loaded d-acts import to fix issue #188.

…and subclassof assertions that referenced anonymous resources, and re-loaded d-acts import to fix issue #188.
@dillerm
Copy link
Collaborator Author

dillerm commented Jan 7, 2024

@matentzn , I've fixed the errors caused by the obsolete classes that had equivalent class axioms and subclass axioms that referenced an anonymous resource. I left the other deprecated_class_reference errors alone since they are caused by obsolete classes that have not been moved to the 'ObsoleteClass' hierarchy. I believe we've discussed this in the past, but our rationale for not touching those obsolete classes is that any data annotated with them could become inaccessible. One question we have about this is whether these violations would end up breaking the build process for releases.

@matentzn
Copy link
Collaborator

matentzn commented Jan 7, 2024

Great! seems QC is happy with it! Are you sure you want to update the release files like this? Maybe better to only update the edit file first, then the import in a separate PR, and then do a proper release? Like this, some release files will be different than others..

@dillerm
Copy link
Collaborator Author

dillerm commented Jan 7, 2024

@matentzn , good point. I will close this pull request and open a new one.

@dillerm dillerm closed this Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants