Skip to content

Commit

Permalink
imsm: fix tpv drvies check in add_to_super
Browse files Browse the repository at this point in the history
Before the mentioned patch, the check to verify if IMSM on current
platform supports a use of TPV (other than Intel) disk, was only performed
for non-Intel disks, after it is performed for all. This change causes
inability to use any disk when platform does not support TPV drives,
attempt results in the following error.

mdadm:  Platform configuration does not support non-Intel NVMe drives.
        Please refer to Intel(R) RSTe/VROC user guide.

This change restores the check if the disk is non-Intel.

Fixes: 734e7db ("imsm: Remove warning and refactor add_to_super_imsm code")
Signed-off-by: Blazej Kucman <[email protected]>
  • Loading branch information
bkucman authored and mtkaczyk committed Nov 27, 2024
1 parent eb24054 commit 8032700
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion super-intel.c
Original file line number Diff line number Diff line change
Expand Up @@ -6121,7 +6121,8 @@ static int add_to_super_imsm(struct supertype *st, mdu_disk_info_t *dk,
pr_err("%s controller supports Multi-Path I/O, Intel (R) VROC does not support multipathing\n",
basename(cntrl_path));

if (super->orom && !imsm_orom_has_tpv_support(super->orom)) {
if (super->orom && devpath_to_vendor(pci_dev_path) != 0x8086 &&
!imsm_orom_has_tpv_support(super->orom)) {
pr_err("\tPlatform configuration does not support non-Intel NVMe drives.\n"
"\tPlease refer to Intel(R) RSTe/VROC user guide.\n");
goto error;
Expand Down

0 comments on commit 8032700

Please sign in to comment.