Kuai's custom bitmap patches #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtkaczyk
force-pushed
the
kuai_custom_bitmap_patches
branch
from
0e19e89 to
320ced1
Compare
Prepare to remove the bitmap file support. Signed-off-by: Yu Kuai <[email protected]> Signed-off-by: Mariusz Tkaczyk <[email protected]>
Prepare to remove bitmap file support. Signed-off-by: Yu Kuai <[email protected]> Signed-off-by: Mariusz Tkaczyk <[email protected]>
For the build mode or external metadata, re-add is not supported, because it will not trigger full disk recovery, user should add a new disk to the array instead. Also update test/05r1-re-add-nosuper to reflect this. Signed-off-by: Yu Kuai <[email protected]> Signed-off-by: Mariusz Tkaczyk <[email protected]>
Instead of auto-forcing bitmap only for large arrays, it is more reasonable to let user do the chooice if bimtap is not set. Signed-off-by: Yu Kuai <[email protected]> Signed-off-by: Mariusz Tkaczyk <[email protected]>
Because it's marked deprecated for a long time now, and it's not worthy to support it for new bitmap. Now that we don't need to store filename for bitmap, also declare a new enum type bitmap_type to simplify code. Signed-off-by: Yu Kuai <[email protected]> Signed-off-by: Mariusz Tkaczyk <[email protected]>
mvollmer
reviewed
Jan 7, 2025
| @@ -1535,6 +1535,14 @@ int main(int argc, char *argv[]) | |||
| break; | |||
| } | |||
|
|
|||
| if (!s.bitmap_file) { | |||
| if (c.runstop != 1 && s.level >= 1 && | |||
| ask("To optimalize recovery speed, it is recommended to enable write-indent bitmap, do you want to enable it now?")) | |||
There was a problem hiding this comment.
It's a "write-intent" bitmap, not a "write indent bimtap".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ML: https://lore.kernel.org/linux-raid/[email protected]/T/#t