Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added patch from Agoradesign #87

Open
wants to merge 1 commit into
base: 8.x-1.x
Choose a base branch
from

Conversation

@Berdir
Copy link
Member

Berdir commented Feb 11, 2016

Have a look at onKernelRequestCheckRedirect(), specifically this part:

    // Do the inbound processing so that for example language prefixes are
    // removed.
    $path = $this->pathProcessor->processInbound($request->getPathInfo(), $request);
    $path = ltrim($path, '/');

We should use the same. The fact that we have so many different functions is a left-over from merging global redirect in. I would prefer to merge all those functions somehow together or at least have a single method registered in the event subscriber that then calls the others. Then we can do this in a single place and don't have to duplicate code and waste time doing the same thing twice. Want to take that on?

@agoradesign
Copy link

Sorry to not have enough time to dig into and fully understand the different event handlers of Redirect, but at least here's a updated version of my patch, which works for current dev:

http://downloads.agoradesign.at/drupal/patches/redirect/fix_multilingual_redirects-v2.patch

@charginghawk
Copy link

FYI, as this repo is deprecated, this issue has been continued at: https://www.drupal.org/node/2704213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants