Skip to content

Commit

Permalink
update files changes in cpp17 branch (#568)
Browse files Browse the repository at this point in the history 
* us VS "unit tests" as they don't need extra stuff

* add test_tree

* add remaining NRT tests

* start adding nitf_ unittests

* add some simple nitf unittests

* hook up more "nitf" unit-tests

* hookup test_tre_mods

* move C++ unit-test to Test++

* replace Google "Test" with Visual Studio "UnitTest"

* start converting Tests++ to VS-test

* use universal references to better preserve actual types

* move another test case to UnitTests++

* trying to get new unittest working with CMake

* don't need these changes from feature/j2k here

* use buildPluginDir() utility

* get unit-tests to compile as Visual Studio tests

* find path to shares

* move UnitTest++ to Test++

* update TEST_ macros

* use same Test.h for both projects

* Fix CodeQL diagnostics

* use std::span

* try to fix compile error on Linux

* tweak OutputStream::write() overloads

* use full name for Assert

* Squashed commit of the following:

commit ac10a6d3c50ab31806563d4043dd86fd2fe0396f
Author: J. Daniel Smith <[email protected]>
Date:   Thu Jun 23 12:18:33 2022 -0400

    Build with latest VS2022

commit b0743a3cce06c54d41ca7d381365b7e274a6fee8
Author: J. Daniel Smith <[email protected]>
Date:   Fri Jun 10 21:49:01 2022 -0400

    add std::nothrow_t overloads

commit 19c64270477299f31fab131c9b49e370ed000bbf
Author: J. Daniel Smith <[email protected]>
Date:   Fri Jun 10 17:39:54 2022 -0400

    overloads for non-throwing index()

commit 94572aa9ea01dc205b057b043cbea90a2e071994
Author: J. Daniel Smith <[email protected]>
Date:   Fri Jun 10 17:12:03 2022 -0400

    expose routines so that the map doesn't have to be named string_to_enum

commit f6237fe795e8731405af010be8d6c844016886f9
Author: J. Daniel Smith <[email protected]>
Date:   Fri Jun 10 15:09:56 2022 -0400

    no longer necessary to specialize string_to_enum(); it doesn't work well in other namespaces

commit 96e0b97227e7793114a3b6c9b47a75e31075008b
Merge: f656114f 3e38c39a
Author: J. Daniel Smith <[email protected]>
Date:   Fri Jun 10 14:32:57 2022 -0400

    Merge branch 'master' into feature/simplify-cpp-api

commit f656114f2b18c14a51be6969c2924464c447ca08
Author: Dan Smith <[email protected]>
Date:   Fri Nov 5 10:38:32 2021 -0400

    sys::byte -> nitf::byte

commit 8cb2c9890bb7e3c64b845694fe10c67e97ab3eaa
Merge: c3a76f4f 888ae929
Author: Dan Smith <[email protected]>
Date:   Fri Nov 5 10:21:25 2021 -0400

    Merge branch 'master' into feature/simplify-cpp-api

commit c3a76f4f60bb9de9de10225e03dcfc93ec093a06
Merge: fc3573f4 1a19b6b6
Author: Dan Smith <[email protected]>
Date:   Fri Sep 17 09:16:24 2021 -0400

    Merge branch 'master' into feature/simplify-cpp-api

commit fc3573f42ad9e738fcc079d56f474a43d6cb0f8b
Author: Dan Smith <[email protected]>
Date:   Fri Sep 17 09:01:18 2021 -0400

    tweak "enum"s; borrowed from SIX

commit 92ccc2732878762eece73edfb9bca0ca3bc129f9
Author: Dan Smith <[email protected]>
Date:   Fri Sep 17 08:58:28 2021 -0400

    Squashed commit of the following:

    commit cf5cde0f334dcfabbf73e367a25973a633250d5b
    Author: Dan Smith <[email protected]>
    Date:   Fri Sep 17 08:57:31 2021 -0400

        latest from coda-oss

    commit b5d29569ea38e8650740fe570b498163c9566c09
    Merge: 5b82b763 0db498f1
    Author: Dan Smith <[email protected]>
    Date:   Fri Sep 17 08:47:38 2021 -0400

        Merge branch 'master' into develop/update_coda-oss

    commit 5b82b763519fc81d37216a5fa932047fd7c6d384
    Author: Dan Smith <[email protected]>
    Date:   Wed Aug 25 13:51:55 2021 -0400

        latest from coda-oss

    commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25
    Merge: ef447eba 9388d5cf
    Author: Dan Smith <[email protected]>
    Date:   Wed Aug 25 13:47:56 2021 -0400

        Merge branch 'master' into develop/update_coda-oss

    commit ef447eba3cb61d66552e052da4e8cafc41f6a38b
    Author: Dan Smith <[email protected]>
    Date:   Wed Aug 25 11:50:09 2021 -0400

        latest from coda-oss

    commit a4d7c89352101b6609c1da9d897323f9c0f413f1
    Merge: efd2e8b2 81278527
    Author: Dan Smith <[email protected]>
    Date:   Wed Aug 25 11:43:51 2021 -0400

        Merge branch 'master' into develop/update_coda-oss

    commit efd2e8b26303e4403040172f9a4d705e95834347
    Merge: 82871b06 c8186387
    Author: Dan Smith <[email protected]>
    Date:   Wed Aug 25 10:28:34 2021 -0400

        Merge branch 'master' into develop/update_coda-oss

    commit 82871b061c6933a4adb31db9ac82e059cb421449
    Author: Dan Smith <[email protected]>
    Date:   Wed Aug 25 09:58:24 2021 -0400

        remove unused drivers

    commit b6bda69baaec7f6df017b7067f26156b6476fb78
    Author: Dan Smith <[email protected]>
    Date:   Wed Aug 25 09:52:59 2021 -0400

        latest from coda-oss

    commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221
    Merge: d0a90807 dc000a51
    Author: Dan Smith <[email protected]>
    Date:   Wed Aug 25 09:45:51 2021 -0400

        Merge branch 'master' into develop/update_coda-oss

    commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d
    Author: Dan Smith <[email protected]>
    Date:   Mon Aug 16 09:00:51 2021 -0400

        latest from coda-oss

    commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19
    Merge: 81f20046 7af555d6
    Author: Dan Smith <[email protected]>
    Date:   Mon Aug 16 08:50:50 2021 -0400

        Merge branch 'master' into develop/update_coda-oss

    commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b
    Merge: acea5259 cb37a8cf
    Author: Dan Smith <[email protected]>
    Date:   Wed Aug 11 10:34:00 2021 -0400

        Merge branch 'master' into develop/update_coda-oss

    commit acea52593e91be6c3eed1d875c89860cd230004a
    Author: Dan Smith <[email protected]>
    Date:   Wed Aug 11 10:30:14 2021 -0400

        latest from coda-oss

    commit 1a4ce530b8452f397bf7877f128ae9154ac0caad
    Author: Dan Smith <[email protected]>
    Date:   Wed Aug 11 10:18:46 2021 -0400

        Squashed commit of the following:

        commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce
        Author: Dan Smith <[email protected]>
        Date:   Wed Aug 11 10:04:32 2021 -0400

            mem::SharedPtr -> std::shared_ptr

        commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3
        Merge: a565fa10 1b6cfe09
        Author: Dan Smith <[email protected]>
        Date:   Wed Aug 11 10:01:33 2021 -0400

            Merge branch 'master' into feature/remove_compiler_warnings

        commit a565fa103eb0cbba332c8ef81f7908597af01595
        Merge: 39a4a874 835da56f
        Author: Dan Smith <[email protected]>
        Date:   Thu Jul 29 10:53:11 2021 -0400

            Merge branch 'master' into feature/remove_compiler_warnings

        commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4
        Author: Dan Smith <[email protected]>
        Date:   Tue Jun 22 10:27:08 2021 -0400

            give up on trying to do a Debug build

        commit 2447502a3514ab564e95f851419f9f31f83135b9
        Author: Dan Smith <[email protected]>
        Date:   Tue Jun 22 10:08:27 2021 -0400

            no Python for debug builds

        commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a
        Author: Dan Smith <[email protected]>
        Date:   Tue Jun 22 09:52:38 2021 -0400

            spaces instead of tabs

        commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9
        Author: Dan Smith <[email protected]>
        Date:   Tue Jun 22 09:50:37 2021 -0400

            do a "Debug" CMAKE build too

        commit af432c68e526b442ceb8037e4795c60e1445d0a2
        Author: Dan Smith <[email protected]>
        Date:   Tue Jun 22 09:46:36 2021 -0400

            Squashed commit of the following:

            commit c4a794b83dce36c35f526c329c04c98e7edcfbe6
            Author: Dan Smith <[email protected]>
            Date:   Tue Jun 22 09:46:11 2021 -0400

                latest from coda-oss

            commit dac28609f60952e606a6fad5f5b5888a17b710ee
            Author: Dan Smith <[email protected]>
            Date:   Mon Jun 21 10:19:56 2021 -0400

                fix RowCol::cast() again :-(

            commit b6af85633fd3b16205ae5442ab95cb247e22c25f
            Author: Dan Smith <[email protected]>
            Date:   Mon Jun 21 10:11:07 2021 -0400

                "final" breaks SWIG; hide gsl::narrow_cast

            commit eec5c064243b1e4186d03b8da2318aa5a13f709b
            Merge: cc85657c 7bb82996
            Author: Dan Smith <[email protected]>
            Date:   Mon Jun 21 10:05:28 2021 -0400

                Merge branch 'master' into develop/update_coda-oss

            commit cc85657c0b3c710befaea1064bfaf39595d7a039
            Author: Dan Smith <[email protected]>
            Date:   Thu Jun 17 08:56:52 2021 -0400

                no mt/tests

            commit 8de6f1a3e3b288dca60a024a539452f03b412014
            Author: Dan Smith <[email protected]>
            Date:   Thu Jun 17 08:40:26 2021 -0400

                latest from coda-oss

            commit 3a668844f4908838197831958e9eb2374a4664d7
            Merge: 639694bf 98e6bcf5
            Author: Dan Smith <[email protected]>
            Date:   Thu Jun 17 08:36:30 2021 -0400

                Merge branch 'master' into develop/update_coda-oss

            commit 639694bfcfd465d658489e277d41ff8a068d5c1f
            Author: Dan Smith <[email protected]>
            Date:   Thu Jun 10 15:47:12 2021 -0400

                latest updates from coda-oss

            commit 95fe355382fb95ec01afac6153283b73c069076a
            Merge: 73995168 ffd5aa85
            Author: Dan Smith <[email protected]>
            Date:   Thu Jun 10 15:39:35 2021 -0400

                Merge branch 'master' into develop/update_coda-oss

        commit 5351b804c0cd99751997b7cab627b81fb8c9f296
        Author: Dan Smith <[email protected]>
        Date:   Mon Jun 21 10:20:18 2021 -0400

            Squashed commit of the following:

            commit dac28609f60952e606a6fad5f5b5888a17b710ee
            Author: Dan Smith <[email protected]>
            Date:   Mon Jun 21 10:19:56 2021 -0400

                fix RowCol::cast() again :-(

            commit b6af85633fd3b16205ae5442ab95cb247e22c25f
            Author: Dan Smith <[email protected]>
            Date:   Mon Jun 21 10:11:07 2021 -0400

                "final" breaks SWIG; hide gsl::narrow_cast

            commit eec5c064243b1e4186d03b8da2318aa5a13f709b
            Merge: cc85657c 7bb82996
            Author: Dan Smith <[email protected]>
            Date:   Mon Jun 21 10:05:28 2021 -0400

                Merge branch 'master' into develop/update_coda-oss

            commit cc85657c0b3c710befaea1064bfaf39595d7a039
            Author: Dan Smith <[email protected]>
            Date:   Thu Jun 17 08:56:52 2021 -0400

                no mt/tests

            commit 8de6f1a3e3b288dca60a024a539452f03b412014
            Author: Dan Smith <[email protected]>
            Date:   Thu Jun 17 08:40:26 2021 -0400

                latest from coda-oss

            commit 3a668844f4908838197831958e9eb2374a4664d7
            Merge: 639694bf 98e6bcf5
            Author: Dan Smith <[email protected]>
            Date:   Thu Jun 17 08:36:30 2021 -0400

                Merge branch 'master' into develop/update_coda-oss

            commit 639694bfcfd465d658489e277d41ff8a068d5c1f
            Author: Dan Smith <[email protected]>
            Date:   Thu Jun 10 15:47:12 2021 -0400

                latest updates from coda-oss

            commit 95fe355382fb95ec01afac6153283b73c069076a
            Merge: 73995168 ffd5aa85
            Author: Dan Smith <[email protected]>
            Date:   Thu Jun 10 15:39:35 2021 -0400

                Merge branch 'master' into develop/update_coda-oss

        commit ebf45b1b971a2a911984f8d0c4add239fcade245
        Author: Dan Smith <[email protected]>
        Date:   Thu Jun 17 11:54:46 2021 -0400

            nitf::byte

        commit d785c54ff2c3242d41c24f38b9a599233443083d
        Author: Dan Smith <[email protected]>
        Date:   Thu Jun 17 09:48:49 2021 -0400

            getCornersAsLatLons() should be w/o "const"

        commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112
        Merge: e6978bf2 7bb82996
        Author: Dan Smith <[email protected]>
        Date:   Thu Jun 17 09:47:40 2021 -0400

            Merge branch 'master' into feature/remove_compiler_warnings

        commit e6978bf27a161ac278426271f4a8098cdd5686ab
        Merge: c51be8f8 98e6bcf5
        Author: Dan Smith <[email protected]>
        Date:   Thu Jun 17 08:41:48 2021 -0400

            Merge branch 'master' into feature/remove_compiler_warnings

        commit c51be8f8020977907b9a6061ff7f0a53d92b51a7
        Author: Dan Smith <[email protected]>
        Date:   Wed Jun 16 17:27:12 2021 -0400

            "noexcept(false)" is a breaking change

        commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b
        Author: Dan Smith <[email protected]>
        Date:   Wed Jun 16 17:01:59 2021 -0400

            another "noexcept" fix

        commit 25c5b47d639210ff724daf91694968f3b8ea10ce
        Author: Dan Smith <[email protected]>
        Date:   Wed Jun 16 15:03:20 2021 -0400

            "noexcept" can break derived classes

        commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b
        Author: Dan Smith <[email protected]>
        Date:   Wed Jun 16 14:23:50 2021 -0400

            we're using gsl::span

        commit c5d4ba86cd999b071681efb3477553bc3979c6f9
        Author: Dan Smith <[email protected]>
        Date:   Wed Jun 16 14:13:32 2021 -0400

            mark throwing constructors with noexcept(false)

        commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb
        Author: Dan Smith <[email protected]>
        Date:   Wed Jun 16 13:53:02 2021 -0400

            more "noexcept" cleanup

        commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3
        Author: Dan Smith <[email protected]>
        Date:   Wed Jun 16 13:41:06 2021 -0400

            cleanup "noexcept" a little bit

        commit c8d6126f3af0cf7a412f6a6505ec9625c368854f
        Author: Dan Smith <[email protected]>
        Date:   Wed Jun 16 13:19:08 2021 -0400

            remove array -> pointer decay

        commit 2075e2e412456aaa5f2494474405477a33113b63
        Author: Dan Smith <[email protected]>
        Date:   Wed Jun 16 12:53:29 2021 -0400

            mark functions "noexcept" as indicated by code-analysis

        commit b4652e9370c34c0841804804e2ed6029858f6949
        Author: Dan Smith <[email protected]>
        Date:   Wed Jun 16 12:23:37 2021 -0400

            Revert "obey the "rule of 5.""

            This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa.

        commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7
        Author: Dan Smith <[email protected]>
        Date:   Wed Jun 16 11:56:47 2021 -0400

            TRE_setField() now takes "const" NITF_DATA*

        commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa
        Author: Dan Smith <[email protected]>
        Date:   Wed Jun 16 11:26:06 2021 -0400

            obey the "rule of 5."

        commit d008bf401676f8ca88ad9ce5dbe94e39423b904c
        Author: Dan Smith <[email protected]>
        Date:   Tue Jun 15 08:30:28 2021 -0400

            fix new code-analysis diagnostics

        commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a
        Merge: e2c3a7a3 c3dc8220
        Author: Dan Smith <[email protected]>
        Date:   Mon Jun 14 09:16:41 2021 -0400

            Merge branch 'master' into feature/remove_compiler_warnings

        commit e2c3a7a3b23273b818431c748932dddd70da231b
        Merge: b6014390 a6cec9df
        Author: Dan Smith <[email protected]>
        Date:   Thu May 27 14:39:23 2021 -0400

            Merge branch 'master' into feature/remove_compiler_warnings

        commit b6014390c83702b4e8e566565d5eb7168c1638b0
        Merge: 7e45fb9f 73995168
        Author: Dan Smith <[email protected]>
        Date:   Thu May 27 13:24:07 2021 -0400

            Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

        commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437
        Merge: 66d7e894 05afcb99
        Author: Dan Smith <[email protected]>
        Date:   Thu May 27 13:04:45 2021 -0400

            Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

        commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3
        Merge: 88e6a046 f4b80a31
        Author: Dan Smith <[email protected]>
        Date:   Thu May 27 13:04:33 2021 -0400

            Merge branch 'master' into feature/remove_compiler_warnings

        commit 88e6a046d10e805ca478878224d0a57084e91941
        Author: Dan Smith <[email protected]>
        Date:   Wed May 26 10:59:56 2021 -0400

            cleanup for VS2019 16.10

        commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40
        Author: Dan Smith <[email protected]>
        Date:   Tue May 25 16:46:44 2021 -0400

            C++20 doesn't like our use of gsl::make_span

        commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce
        Merge: dd12167d a2352f25
        Author: Dan Smith <[email protected]>
        Date:   Mon May 24 16:04:20 2021 -0400

            Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

        commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8
        Merge: 994faf7d 4ddaf23d
        Author: Dan Smith <[email protected]>
        Date:   Mon May 24 15:26:45 2021 -0400

            Merge branch 'master' into feature/remove_compiler_warnings

        commit 994faf7dc516700a8213087a9a3696799190ce58
        Merge: b8025652 4f1b857a
        Author: Dan Smith <[email protected]>
        Date:   Mon May 24 15:17:12 2021 -0400

            Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

        commit b8025652318622158b0cb70f6080b1e32234cc44
        Merge: b110d9b9 2a57741c
        Author: Dan Smith <[email protected]>
        Date:   Mon May 24 15:12:10 2021 -0400

            Merge branch 'master' into feature/remove_compiler_warnings

        commit b110d9b9d7f5d45615ebb5301aa69671a050fe68
        Merge: 93160fd8 d99322d3
        Author: Dan Smith <[email protected]>
        Date:   Mon May 24 14:39:15 2021 -0400

            Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

        commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6
        Merge: 39e283bc d3fab714
        Author: Dan Smith <[email protected]>
        Date:   Mon May 24 14:39:07 2021 -0400

            Merge branch 'master' into feature/remove_compiler_warnings

        commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4
        Author: Dan Smith <[email protected]>
        Date:   Wed May 19 15:28:21 2021 -0400

            reduce use of .c_str()

        commit e0bc08bef56bfea53b93ee665032d85e5e30ab77
        Author: Dan Smith <[email protected]>
        Date:   Wed May 19 14:52:18 2021 -0400

            reduce try/catch code duplication with a few lambdas

        commit 728eb1e2122f2b2646656e78690b3ebf532ecc55
        Author: Dan Smith <[email protected]>
        Date:   Wed May 19 14:52:01 2021 -0400

            utility routines to initialize nrt_Error from other things

        commit 13e80d90732eb997d5783967a9bf0fd802db2824
        Merge: 3a1c7373 9aee934e
        Author: Dan Smith <[email protected]>
        Date:   Mon May 17 10:33:48 2021 -0400

            Merge branch 'master' into feature/remove_compiler_warnings

        commit 3a1c7373b1063eefab07ca2b94339971c6f01303
        Author: Dan Smith <[email protected]>
        Date:   Mon May 17 09:34:50 2021 -0400

            changes from six to reduce code-analysis diagnostics

        commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a
        Merge: 14be4581 7be6c13b
        Author: Dan Smith <[email protected]>
        Date:   Mon May 17 09:29:58 2021 -0400

            Merge branch 'master' into feature/remove_compiler_warnings

        commit 14be458157cb70d3094f5a460835656370236906
        Merge: 8e8f5bf9 d0117954
        Author: Dan Smith <[email protected]>
        Date:   Tue May 4 14:44:56 2021 -0400

            Merge branch 'master' into feature/remove_compiler_warnings

        commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9
        Merge: 158ee6ea 4e806f4e
        Author: Dan Smith <[email protected]>
        Date:   Tue May 4 14:17:42 2021 -0400

            Merge branch 'feature/shared-library' into feature/remove_compiler_warnings

        commit 158ee6ea9759a1a1d556b26350d6a88381abdb27
        Merge: 758f5977 a16f72b0
        Author: Dan Smith <[email protected]>
        Date:   Tue May 4 14:14:20 2021 -0400

            Merge branch 'master' into feature/remove_compiler_warnings

        commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5
        Author: Dan Smith <[email protected]>
        Date:   Mon May 3 14:01:10 2021 -0400

            export more classes; but sure nitf.hpp gets everything

        commit 903e1b8b34dcba14e15b87d657838d78f27f1d78
        Author: Dan Smith <[email protected]>
        Date:   Mon May 3 11:27:44 2021 -0400

            #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...'

        commit 32f5529a8bb0364a0168273709d7fdeef0530991
        Merge: 02112ced a16f72b0
        Author: Dan Smith <[email protected]>
        Date:   Sat May 1 14:44:11 2021 -0400

            Merge branch 'master' into feature/shared-library

        commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821
        Author: Dan Smith <[email protected]>
        Date:   Sat May 1 14:06:35 2021 -0400

            building mt/tests crashes GCC on github

        commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6
        Author: Dan Smith <[email protected]>
        Date:   Sat May 1 13:01:10 2021 -0400

            don't need a separate project for the DLL anymore

        commit 94fc53280464472cd70620b74340e4a598cb2452
        Author: Dan Smith <[email protected]>
        Date:   Sat May 1 12:55:04 2021 -0400

            make it easier for clients to consume nitf-c++ as a DLL

        commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44
        Author: Dan Smith <[email protected]>
        Date:   Wed Apr 28 17:35:44 2021 -0400

            wrap nitf_ImageIO_getMaskInfo() for unit-tests

        commit 2636b229454f5ae0914dd02e9387e7abf07eda0d
        Author: Dan Smith <[email protected]>
        Date:   Wed Apr 28 17:02:50 2021 -0400

            test_tre_read needs C, not C++ routines

        commit f6328bcd61452a3625089220f352e870c075c4f3
        Author: Dan Smith <[email protected]>
        Date:   Wed Apr 28 16:08:43 2021 -0400

            more wrapping of C APIs in C++ for unit-tests

        commit de329e3065e5f51c4c6eb0420d74067b7fa20d21
        Author: Dan Smith <[email protected]>
        Date:   Wed Apr 28 15:55:31 2021 -0400

            more C APIs exposed through C++ for unit-testing

        commit f552322088bd2f22e3045a495850bd96c25ccdfb
        Author: Dan Smith <[email protected]>
        Date:   Wed Apr 28 15:31:48 2021 -0400

            "Test" project should reference nitf-c, not nitf-c++

        commit 66ee139887cb6a7c7764a80097caea46e373f657
        Author: Dan Smith <[email protected]>
        Date:   Wed Apr 28 15:31:15 2021 -0400

            allow unit-tests to use C++ API rather than direct calls to C

        commit 049b9acd7e677f7f8c42301b0ee84f6185166171
        Author: Dan Smith <[email protected]>
        Date:   Wed Apr 28 15:10:22 2021 -0400

            more tweaks for building as a DLL

        commit 1dc4103157c9319885ac81c30efe65659e254374
        Author: Dan Smith <[email protected]>
        Date:   Wed Apr 28 14:04:16 2021 -0400

            finish separating unit-tests into C and C++

        commit d6541484f500c757ccdcaa9cfd091c1040ec8069
        Author: Dan Smith <[email protected]>
        Date:   Wed Apr 28 13:45:50 2021 -0400

            begin work on separating C and C++ unit-tests

        commit 1754c79b68730c81c81da84be67c439c6bb062c5
        Author: Dan Smith <[email protected]>
        Date:   Wed Apr 28 13:05:46 2021 -0400

            tweak Field::get()

        commit c654395457d1557f83f6b1f29e50a77bc8c2d56e
        Author: Dan Smith <[email protected]>
        Date:   Wed Apr 28 12:46:01 2021 -0400

            add new files to CMakeLists.txt

        commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947
        Author: Dan Smith <[email protected]>
        Date:   Wed Apr 28 12:23:36 2021 -0400

            need to force-resolve the _destruct() functions

        commit bb61a5762a38ab4423b2bcb7ec64f013312ed496
        Author: Dan Smith <[email protected]>
        Date:   Wed Apr 28 10:34:58 2021 -0400

            set path to CODA-OSS libraries

        commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33
        Author: Dan Smith <[email protected]>
        Date:   Wed Apr 28 10:07:40 2021 -0400

            _LIB and _WINDLL are part of Visual Studio, not MSVC

        commit b05bd737c9a9d5e2522a5ae14917b3b955708d53
        Author: Dan Smith <[email protected]>
        Date:   Tue Apr 27 18:01:47 2021 -0400

            remove reference to nitf-c from "Test" project

        commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f
        Author: Dan Smith <[email protected]>
        Date:   Tue Apr 27 17:05:01 2021 -0400

            use NITRO_NITFCPP_API to export classes/functions

        commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0
        Author: Dan Smith <[email protected]>
        Date:   Tue Apr 27 15:36:19 2021 -0400

            Create nitf-c++-dll.vcxproj

        commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a
        Author: Dan Smith <[email protected]>
        Date:   Tue Apr 27 15:07:05 2021 -0400

            infrastructure for exporting symbols from nitf-c++

        commit 758f5977222cb1bc833474198eca6e773725dedc
        Author: Dan Smith <[email protected]>
        Date:   Tue Apr 27 11:23:34 2021 -0400

            adjust CMakeLists.txt to turn on more compiler warnings

        commit f5d9c21f568707cd348411bd31bbb405800ca974
        Author: Dan Smith <[email protected]>
        Date:   Mon Apr 26 14:32:29 2021 -0400

            avoid avoid array -> pointer decay in nitf::Error

        commit b682e55713cfedcaae0cafbb52404c666c989aab
        Merge: 02f700e4 35c5f4ad
        Author: Dan Smith <[email protected]>
        Date:   Mon Apr 26 14:29:51 2021 -0400

            Merge branch 'master' into feature/remove_compiler_warnings

        commit 02f700e46abebd7a4afcea343696efd71cb4b345
        Author: Dan Smith <[email protected]>
        Date:   Mon Apr 26 11:22:52 2021 -0400

            ubuntu-latest

        commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111
        Merge: 40af41a9 273c39e8
        Author: Dan Smith <[email protected]>
        Date:   Mon Apr 26 11:19:40 2021 -0400

            Merge branch 'master' into feature/remove_compiler_warnings

        commit 40af41a9444cc1bc066080a4b160a26e18ac6fed
        Author: Dan Smith <[email protected]>
        Date:   Tue Apr 20 10:07:18 2021 -0400

            build with fewer compiler warnings/code-analysis diagnostics

        commit 9d4d36651dc570bc45b747b43087e9de675deb15
        Merge: cfe591ab 6e6819db
        Author: Dan Smith <[email protected]>
        Date:   Tue Apr 20 09:57:19 2021 -0400

            Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

        commit cfe591ab71072eb672c575f2d1de176ba06cdff9
        Author: Dan Smith <[email protected]>
        Date:   Mon Apr 19 11:27:40 2021 -0400

            #includes for std::make_unique

        commit c150cc2867f35ef63913885e8860826c829f0d53
        Author: Dan Smith <[email protected]>
        Date:   Mon Apr 19 11:12:03 2021 -0400

            remove more explicit new and delete

        commit e3857e573329d9c00889afffc7902d67eaa0f386
        Author: Dan Smith <[email protected]>
        Date:   Mon Apr 19 10:02:30 2021 -0400

            reduce explicit use of new and delete

        commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08
        Merge: c7b29b1d 7af8169b
        Author: Dan Smith <[email protected]>
        Date:   Sat Apr 17 16:37:07 2021 -0400

            Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

        commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168
        Author: Dan Smith <[email protected]>
        Date:   Sat Apr 17 16:29:32 2021 -0400

            turn on more code-analysis diagnostics

        commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2
        Merge: bcb6bfc4 4b0062b7
        Author: Dan Smith <[email protected]>
        Date:   Sat Apr 17 15:53:32 2021 -0400

            Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

        commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411
        Merge: 6f4befc1 4aa689b9
        Author: Dan Smith <[email protected]>
        Date:   Sat Apr 17 15:45:28 2021 -0400

            Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

        commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e
        Author: Dan Smith <[email protected]>
        Date:   Sat Apr 17 15:44:53 2021 -0400

            explicitly =delete copy/assignment

        commit e381bc348de5c3dfe1a472ad48b61f44cfccf546
        Merge: 1a7b623b fdc62abd
        Author: Dan Smith <[email protected]>
        Date:   Sat Apr 17 15:19:56 2021 -0400

            Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

        commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f
        Merge: 5d07dd64 014917fe
        Author: Dan Smith <[email protected]>
        Date:   Sat Apr 17 15:01:04 2021 -0400

            Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

        commit 5d07dd64afc234e8aec83b1086fe8deb51a12084
        Merge: 012b9b4f cd50f937
        Author: Dan Smith <[email protected]>
        Date:   Sat Apr 17 14:47:16 2021 -0400

            Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

        commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71
        Author: Dan Smith <[email protected]>
        Date:   Sat Apr 17 14:47:07 2021 -0400

            Update coda-oss.hpp

        commit 81b99e75295e4beed74729dddd61b78d1d68ec4d
        Author: Dan Smith <[email protected]>
        Date:   Sat Apr 17 14:45:42 2021 -0400

             PlatformToolset() is no longer used

        commit 945e2a284c7a306fb87f8113f18242cc592bbdb8
        Merge: b96c0e9c 9532c538
        Author: Dan Smith <[email protected]>
        Date:   Sat Apr 17 14:19:53 2021 -0400

            Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

        commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1
        Author: Dan Smith <[email protected]>
        Date:   Sat Apr 17 14:19:22 2021 -0400

            more code-analysis cleanup

        commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694
        Author: Dan Smith <[email protected]>
        Date:   Sat Apr 17 13:40:36 2021 -0400

            no import/logging.h

        commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51
        Merge: 7e54d7e9 32609f76
        Author: Dan Smith <[email protected]>
        Date:   Sat Apr 17 13:07:23 2021 -0400

            Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

        commit 7e54d7e9221008d883c2da195cf2d3f321f76442
        Author: Dan Smith <[email protected]>
        Date:   Mon Apr 12 14:04:01 2021 -0400

            wrap nitf_Error to reduce code-analysis diagnostics

        commit 18c18a206f95fb078f683c06c71504321cc470a4
        Author: Dan Smith <[email protected]>
        Date:   Mon Apr 12 13:33:50 2021 -0400

            adjust the code-analysis diagnostics that are disabled

        commit e136900ae637eb0a2d9cb282eb03875f32eaad82
        Merge: dddbb27b 1ff904eb
        Author: Dan Smith <[email protected]>
        Date:   Mon Apr 12 13:32:48 2021 -0400

            Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

        commit dddbb27b70364ae737bef67f84064ae18409943c
        Merge: 8b3483cf 20f4e614
        Author: Dan Smith <[email protected]>
        Date:   Mon Apr 12 12:43:06 2021 -0400

            Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

        commit 8b3483cfe42899487735297a85e83dfa23ea7eff
        Author: Dan Smith <[email protected]>
        Date:   Mon Apr 12 12:39:12 2021 -0400

            slam in changes from "master"

        commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a
        Merge: 316cf602 298536f4
        Author: Dan Smith <[email protected]>
        Date:   Mon Apr 12 12:32:05 2021 -0400

            Merge branch 'master' into feature/remove_compiler_warnings

        commit 316cf602098d8a486977897a3d032bcd53accf21
        Author: Dan Smith <[email protected]>
        Date:   Mon Apr 12 12:31:35 2021 -0400

            PlatformToolset() isn't used

        commit 291b497a910922fd084286b042786aa4d339d055
        Author: Dan Smith <[email protected]>
        Date:   Mon Apr 5 16:09:21 2021 -0400

            trying ubuntu-18.04

        commit 0669d206c30c7da14f942ae3df25810dfefd300f
        Author: Dan Smith <[email protected]>
        Date:   Mon Apr 5 15:50:26 2021 -0400

            try explicitly setting ubuntu versoin

        commit 0458685824304bd4a6e02758f981556890db9048
        Author: Dan Smith <[email protected]>
        Date:   Mon Apr 5 14:18:13 2021 -0400

            still trying to figure out broken GitHub build

        commit 024814b37fd3a24597e42c7b18087fcc6efa31e3
        Author: Dan Smith <[email protected]>
        Date:   Mon Apr 5 13:04:02 2021 -0400

            does this build on GitHub ... ?

        commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044
        Author: Dan Smith <[email protected]>
        Date:   Mon Apr 5 12:42:59 2021 -0400

            trying to figure out what broke GitHub build

    commit 5ec4a357e2bf260855ed7497fc7b04700b41829e
    Merge: 24e59602 1b6cfe09
    Author: Dan Smith <[email protected]>
    Date:   Wed Aug 11 10:18:33 2021 -0400

        Merge branch 'master' into develop/update_coda-oss

    commit 24e596027dd7d10acded64ed1f269a29903264d4
    Author: Dan Smith <[email protected]>
    Date:   Mon Aug 2 11:16:14 2021 -0400

        latest from coda-oss

    commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4
    Merge: ebe39048 2229fbde
    Author: Dan Smith <[email protected]>
    Date:   Mon Aug 2 11:09:57 2021 -0400

        Merge branch 'master' into develop/update_coda-oss

    commit ebe390482453f0136f8d980016e89046064ff9b4
    Author: Dan Smith <[email protected]>
    Date:   Thu Jul 29 10:59:50 2021 -0400

        latest from coda-oss

    commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54
    Merge: c4a794b8 835da56f
    Author: Dan Smith <[email protected]>
    Date:   Thu Jul 29 10:53:34 2021 -0400

        Merge branch 'master' into develop/update_coda-oss

    commit c4a794b83dce36c35f526c329c04c98e7edcfbe6
    Author: Dan Smith <[email protected]>
    Date:   Tue Jun 22 09:46:11 2021 -0400

        latest from coda-oss

    commit dac28609f60952e606a6fad5f5b5888a17b710ee
    Author: Dan Smith <[email protected]>
    Date:   Mon Jun 21 10:19:56 2021 -0400

        fix RowCol::cast() again :-(

    commit b6af85633fd3b16205ae5442ab95cb247e22c25f
    Author: Dan Smith <[email protected]>
    Date:   Mon Jun 21 10:11:07 2021 -0400

        "final" breaks SWIG; hide gsl::narrow_cast

    commit eec5c064243b1e4186d03b8da2318aa5a13f709b
    Merge: cc85657c 7bb82996
    Author: Dan Smith <[email protected]>
    Date:   Mon Jun 21 10:05:28 2021 -0400

        Merge branch 'master' into develop/update_coda-oss

    commit cc85657c0b3c710befaea1064bfaf39595d7a039
    Author: Dan Smith <[email protected]>
    Date:   Thu Jun 17 08:56:52 2021 -0400

        no mt/tests

    commit 8de6f1a3e3b288dca60a024a539452f03b412014
    Author: Dan Smith <[email protected]>
    Date:   Thu Jun 17 08:40:26 2021 -0400

        latest from coda-oss

    commit 3a668844f4908838197831958e9eb2374a4664d7
    Merge: 639694bf 98e6bcf5
    Author: Dan Smith <[email protected]>
    Date:   Thu Jun 17 08:36:30 2021 -0400

        Merge branch 'master' into develop/update_coda-oss

    commit 639694bfcfd465d658489e277d41ff8a068d5c1f
    Author: Dan Smith <[email protected]>
    Date:   Thu Jun 10 15:47:12 2021 -0400

        latest updates from coda-oss

    commit 95fe355382fb95ec01afac6153283b73c069076a
    Merge: 73995168 ffd5aa85
    Author: Dan Smith <[email protected]>
    Date:   Thu Jun 10 15:39:35 2021 -0400

        Merge branch 'master' into develop/update_coda-oss

commit b9cef2cbfe1fd8d1238e644dc4e4ac0b39a65053
Author: Dan Smith <[email protected]>
Date:   Fri Sep 10 10:53:57 2021 -0400

    use a normal "enum class" rather than static data members

commit 4a6d3dcf76b96a6ef2e88225e15fd234fcd8575a
Merge: 9ec9f026 0db498f1
Author: Dan Smith <[email protected]>
Date:   Wed Sep 8 16:15:37 2021 -0400

    Merge branch 'master' into feature/simplify-cpp-api

commit 9ec9f026133fdb4a6b9192a3f047bfde468d1591
Author: Dan Smith <[email protected]>
Date:   Mon Aug 23 14:26:41 2021 -0400

    make a strongly-typed BandInfo::Represenation

commit ad54eaa940f6cb1c55c8d7458a855e4a031e8e92
Author: Dan Smith <[email protected]>
Date:   Thu Aug 19 13:42:41 2021 -0400

    Revert "infrastructure for getting ntif::Fields with less repetition of the field name"

    This reverts commit e3ef6531ce3a98bfa7ca02db1a96ebc1376102e0.

commit 232f3620a9d518bd3d6f5f5e40f56501be91e79c
Author: Dan Smith <[email protected]>
Date:   Thu Aug 19 13:42:35 2021 -0400

    Revert "move field-offset code to Object.hpp"

    This reverts commit fcd8ad368965b741dc3c95a54f54301ff71008ed.

commit 5ba52e4da4fb39add720314ae9ede061d0a3f439
Author: Dan Smith <[email protected]>
Date:   Thu Aug 19 13:42:16 2021 -0400

    Revert "first pass at trying to do a simple reflection scheme"

    This reverts commit 295221104c274aefef45cdf4e407315b45b33282.

commit 935683eeeb7b5b8c8efecf04116f2774c0577896
Author: Dan Smith <[email protected]>
Date:   Thu Aug 19 13:42:10 2021 -0400

    Revert "use __VA_ARGS__"

    This reverts commit 02d91710962a4caae71516b2bd40b94c8720c379.

commit b76f4cbd8db01498dbce1f0bc1ec7c2e5ec33a77
Author: Dan Smith <[email protected]>
Date:   Thu Aug 19 13:42:05 2021 -0400

    Revert "try __VA_ARGS__"

    This reverts commit 345351fdfe86727aca3c30fdcb22ac619a935bc1.

commit 345351fdfe86727aca3c30fdcb22ac619a935bc1
Author: Dan Smith <[email protected]>
Date:   Thu Aug 19 12:59:25 2021 -0400

    try __VA_ARGS__

commit 02d91710962a4caae71516b2bd40b94c8720c379
Author: Dan Smith <[email protected]>
Date:   Thu Aug 19 12:35:28 2021 -0400

    use __VA_ARGS__

commit 295221104c274aefef45cdf4e407315b45b33282
Author: Dan Smith <[email protected]>
Date:   Thu Aug 19 12:08:18 2021 -0400

    first pass at trying to do a simple reflection scheme

commit fcd8ad368965b741dc3c95a54f54301ff71008ed
Author: Dan Smith <[email protected]>
Date:   Wed Aug 18 17:00:29 2021 -0400

    move field-offset code to Object.hpp

commit e3ef6531ce3a98bfa7ca02db1a96ebc1376102e0
Author: Dan Smith <[email protected]>
Date:   Wed Aug 18 16:36:23 2021 -0400

    infrastructure for getting ntif::Fields with less repetition of the field name

commit d7b8710887359f09440c146325a5d9199d689931
Author: Dan Smith <[email protected]>
Date:   Wed Aug 18 13:30:06 2021 -0400

    Hook up "property" support; not yet used.

commit a55c927c9ae904b94c36d0245106417f5087cab6
Author: Dan Smith <[email protected]>
Date:   Wed Aug 18 11:51:43 2021 -0400

    simplify creation of nitf::SubWindow

commit 07ff1610052f9cf5c2cd5284775df26ab06b7ff6
Author: Dan Smith <[email protected]>
Date:   Wed Aug 18 11:33:57 2021 -0400

    create/initialize a SubWindow from an ImageHeader

commit 33f199aa0dc212f54c42be1397ecdaf63fb4ca5a
Merge: 3a013fdd dc000a51
Author: Dan Smith <[email protected]>
Date:   Wed Aug 18 11:25:11 2021 -0400

    Merge branch 'master' into feature/simplify-cpp-api

commit 3a013fdd63b52070b6cdd77b93be60e7a2a051a7
Author: Dan Smith <[email protected]>
Date:   Thu May 27 15:32:22 2021 -0400

    remove CodeQL diagnostics

commit 6ff51c070feb025401fea1a17785c03c35531acd
Merge: bde5cad3 75caf49e
Author: Dan Smith <[email protected]>
Date:   Thu May 27 14:59:36 2021 -0400

    Merge branch 'master' into feature/simplify-cpp-api

commit bde5cad35bc151b6207e7d979e8417b101b53ee8
Merge: 653750ae b6014390
Author: Dan Smith <[email protected]>
Date:   Thu May 27 14:02:46 2021 -0400

    Merge branch 'feature/remove_compiler_warnings' into feature/simplify-cpp-api

commit 653750ae888234915d5194f40d342d0541d5a4d5
Merge: 5b9a50bc f4b80a31
Author: Dan Smith <[email protected]>
Date:   Thu May 27 14:02:38 2021 -0400

    Merge branch 'master' into feature/simplify-cpp-api

commit b6014390c83702b4e8e566565d5eb7168c1638b0
Merge: 7e45fb9f 73995168
Author: Dan Smith <[email protected]>
Date:   Thu May 27 13:24:07 2021 -0400

    Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

commit 73995168d5abb6a020ff01425adb8837c24c588b
Author: Dan Smith <[email protected]>
Date:   Thu May 27 13:23:48 2021 -0400

    Delete Span_.h

commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437
Merge: 66d7e894 05afcb99
Author: Dan Smith <[email protected]>
Date:   Thu May 27 13:04:45 2021 -0400

    Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3
Merge: 88e6a046 f4b80a31
Author: Dan Smith <[email protected]>
Date:   Thu May 27 13:04:33 2021 -0400

    Merge branch 'master' into feature/remove_compiler_warnings

commit 05afcb9977aa60f57cd94ffd485c20cdc181f173
Author: Dan Smith <[email protected]>
Date:   Thu May 27 13:04:15 2021 -0400

    latest from coda-oss

commit 88e6a046d10e805ca478878224d0a57084e91941
Author: Dan Smith <[email protected]>
Date:   Wed May 26 10:59:56 2021 -0400

    cleanup for VS2019 16.10

commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40
Author: Dan Smith <[email protected]>
Date:   Tue May 25 16:46:44 2021 -0400

    C++20 doesn't like our use of gsl::make_span

commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce
Merge: dd12167d a2352f25
Author: Dan Smith <[email protected]>
Date:   Mon May 24 16:04:20 2021 -0400

    Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

commit 5b9a50bc289835959dfc2a7f7d7718a5fdf20009
Merge: f2b11a28 4ddaf23d
Author: Dan Smith <[email protected]>
Date:   Mon May 24 15:27:06 2021 -0400

    Merge branch 'master' into feature/simplify-cpp-api

commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7
Merge: 4f1b857a 4ddaf23d
Author: Dan Smith <[email protected]>
Date:   Mon May 24 15:26:56 2021 -0400

    Merge branch 'master' into develop/update_coda-oss

commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8
Merge: 994faf7d 4ddaf23d
Author: Dan Smith <[email protected]>
Date:   Mon May 24 15:26:45 2021 -0400

    Merge branch 'master' into feature/remove_compiler_warnings

commit 994faf7dc516700a8213087a9a3696799190ce58
Merge: b8025652 4f1b857a
Author: Dan Smith <[email protected]>
Date:   Mon May 24 15:17:12 2021 -0400

    Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a
Merge: d99322d3 2a57741c
Author: Dan Smith <[email protected]>
Date:   Mon May 24 15:16:44 2021 -0400

    Merge branch 'master' into develop/update_coda-oss

commit b8025652318622158b0cb70f6080b1e32234cc44
Merge: b110d9b9 2a57741c
Author: Dan Smith <[email protected]>
Date:   Mon May 24 15:12:10 2021 -0400

    Merge branch 'master' into feature/remove_compiler_warnings

commit b110d9b9d7f5d45615ebb5301aa69671a050fe68
Merge: 93160fd8 d99322d3
Author: Dan Smith <[email protected]>
Date:   Mon May 24 14:39:15 2021 -0400

    Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6
Merge: 39e283bc d3fab714
Author: Dan Smith <[email protected]>
Date:   Mon May 24 14:39:07 2021 -0400

    Merge branch 'master' into feature/remove_compiler_warnings

commit d99322d3937cef7443e9c91ef84dd52b8eb86102
Author: Dan Smith <[email protected]>
Date:   Mon May 24 14:38:47 2021 -0400

    changes from coda-oss to reduce code-analysis diagnostics

commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4
Author: Dan Smith <[email protected]>
Date:   Wed May 19 15:28:21 2021 -0400

    reduce use of .c_str()

commit e0bc08bef56bfea53b93ee665032d85e5e30ab77
Author: Dan Smith <[email protected]>
Date:   Wed May 19 14:52:18 2021 -0400

    reduce try/catch code duplication with a few lambdas

commit 728eb1e2122f2b2646656e78690b3ebf532ecc55
Author: Dan Smith <[email protected]>
Date:   Wed May 19 14:52:01 2021 -0400

    utility routines to initialize nrt_Error from other things

commit f2b11a2831aeff4e1fee315932dc44c61860be0e
Merge: c8fd70fa d3fab714
Author: Dan Smith <[email protected]>
Date:   Mon May 17 12:02:26 2021 -0400

    Merge branch 'master' into feature/simplify-cpp-api

commit ade02fa44d395889659278da9cb0448d1b7135fe
Author: Dan Smith <[email protected]>
Date:   Mon May 17 11:45:28 2021 -0400

    don't "compress" build output; everyone should build from source

commit 1b4fa40e013b0833838c330698ad6dd89595e415
Author: Dan Smith <[email protected]>
Date:   Mon May 17 11:20:35 2021 -0400

    latest from "coda-oss"

commit 16633d49e15fc2d5c1394ff399a925d81825adf8
Merge: c5c549f4 8806960a
Author: Dan Smith <[email protected]>
Date:   Mon May 17 11:10:59 2021 -0400

    Merge branch 'master' into develop/update_coda-oss

commit 13e80d90732eb997d5783967a9bf0fd802db2824
Merge: 3a1c7373 9aee934e
Author: Dan Smith <[email protected]>
Date:   Mon May 17 10:33:48 2021 -0400

    Merge branch 'master' into feature/remove_compiler_warnings

commit c8fd70fa5d7aea3ba246e2a14ead5be417bff842
Merge: 74611f09 9aee934e
Author: Dan Smith <[email protected]>
Date:   Mon May 17 10:33:28 2021 -0400

    Merge branch 'master' into feature/simplify-cpp-api

commit 3a1c7373b1063eefab07ca2b94339971c6f01303
Author: Dan Smith <[email protected]>
Date:   Mon May 17 09:34:50 2021 -0400

    changes from six to reduce code-analysis diagnostics

commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a
Merge: 14be4581 7be6c13b
Author: Dan Smith <[email protected]>
Date:   Mon May 17 09:29:58 2021 -0400

    Merge branch 'master' into feature/remove_compiler_warnings

commit 74611f09d251ca4953396d1417aa5bbdfa0978ed
Merge: 7c456134 7be6c13b
Author: Dan Smith <[email protected]>
Date:   Tue May 11 09:36:39 2021 -0400

    Merge branch 'master' into feature/simplify-cpp-api

commit 7c456134f6afbf6f520d5572a852b46f15e1d13b
Merge: 5f81d561 a58e3b36
Author: Dan Smith <[email protected]>
Date:   Tue May 4 15:03:21 2021 -0400

    Merge branch 'feature/shared-library' into feature/simplify-cpp-api

commit a58e3b366fa2d21f2bd8f0f6377256405fb51c35
Merge: 8d8d9662 d4f244ee
Author: Dan Smith <[email protected]>
Date:   Tue May 4 15:02:56 2021 -0400

    Merge branch 'master' into feature/shared-library

commit 5f81d561e700589f5620327e186e3d57c66a1a4e
Merge: 2f038389 d0117954
Author: Dan Smith <[email protected]>
Date:   Tue May 4 14:45:24 2021 -0400

    Merge branch 'master' into feature/simplify-cpp-api

commit 8d8d96626f7e26f6d657c7c14724a47bd3f5d632
Merge: 4e806f4e d0117954
Author: Dan Smith <[email protected]>
Date:   Tue May 4 14:45:09 2021 -0400

    Merge branch 'master' into feature/shared-library

commit 14be458157cb70d3094f5a460835656370236906
Merge: 8e8f5bf9 d0117954
Author: Dan Smith <[email protected]>
Date:   Tue May 4 14:44:56 2021 -0400

    Merge branch 'master' into feature/remove_compiler_warnings

commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9
Merge: 158ee6ea 4e806f4e
Author: Dan Smith <[email protected]>
Date:   Tue May 4 14:17:42 2021 -0400

    Merge branch 'feature/shared-library' into feature/remove_compiler_warnings

commit 158ee6ea9759a1a1d556b26350d6a88381abdb27
Merge: 758f5977 a16f72b0
Author: Dan Smith <[email protected]>
Date:   Tue May 4 14:14:20 2021 -0400

    Merge branch 'master' into feature/remove_compiler_warnings

commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0
Author: Dan Smith <[email protected]>
Date:   Tue May 4 14:09:33 2021 -0400

    latest from coda-oss

commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3
Merge: 0902d4d3 a16f72b0
Author: Dan Smith <[email protected]>
Date:   Tue May 4 14:01:12 2021 -0400

    Merge branch 'master' into develop/update_coda-oss

commit 2f038389fe188dd5c94c00e1a61e5d0f67defb02
Merge: 47b8f0d8 4e806f4e
Author: Dan Smith <[email protected]>
Date:   Tue May 4 13:45:27 2021 -0400

    Merge branch 'feature/shared-library' into feature/simplify-cpp-api

commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5
Author: Dan Smith <[email protected]>
Date:   Mon May 3 14:01:10 2021 -0400

    export more classes; but sure nitf.hpp gets everything

commit 903e1b8b34dcba14e15b87d657838d78f27f1d78
Author: Dan Smith <[email protected]>
Date:   Mon May 3 11:27:44 2021 -0400

    #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...'

commit 47b8f0d8f279e891a788f2b22f58738cec83f9c5
Author: Dan Smith <[email protected]>
Date:   Sat May 1 15:19:43 2021 -0400

    fix WAF build

commit 942e0363cd293ca96f14e4991d49075437a28a17
Author: Dan Smith <[email protected]>
Date:   Sat May 1 15:11:42 2021 -0400

    building mem/tests causes GCC to crash on github

commit 4d484bbdcd015abbfc6010f5180909ae55294bc2
Author: Dan Smith <[email protected]>
Date:   Sat May 1 14:46:39 2021 -0400

    restore change lost in merge from "master"

commit b4db13837ebf98fd720e1ae35c9b076e837e0756
Merge: e55b86ba a16f72b0
Author: Dan Smith <[email protected]>
Date:   Sat May 1 14:45:38 2021 -0400

    Merge branch 'master' into feature/simplify-cpp-api

commit 32f5529a8bb0364a0168273709d7fdeef0530991
Merge: 02112ced a16f72b0
Author: Dan Smith <[email protected]>
Date:   Sat May 1 14:44:11 2021 -0400

    Merge branch 'master' into feature/shared-library

commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821
Author: Dan Smith <[email protected]>
Date:   Sat May 1 14:06:35 2021 -0400

    building mt/tests crashes GCC on github

commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6
Author: Dan Smith <[email protected]>
Date:   Sat May 1 13:01:10 2021 -0400

    don't need a separate project for the DLL anymore

commit 94fc53280464472cd70620b74340e4a598cb2452
Author: Dan Smith <[email protected]>
Date:   Sat May 1 12:55:04 2021 -0400

    make it easier for clients to consume nitf-c++ as a DLL

commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44
Author: Dan Smith <[email protected]>
Date:   Wed Apr 28 17:35:44 2021 -0400

    wrap nitf_ImageIO_getMaskInfo() for unit-tests

commit 2636b229454f5ae0914dd02e9387e7abf07eda0d
Author: Dan Smith <[email protected]>
Date:   Wed Apr 28 17:02:50 2021 -0400

    test_tre_read needs C, not C++ routines

commit f6328bcd61452a3625089220f352e870c075c4f3
Author: Dan Smith <[email protected]>
Date:   Wed Apr 28 16:08:43 2021 -0400

    more wrapping of C APIs in C++ for unit-tests

commit de329e3065e5f51c4c6eb0420d74067b7fa20d21
Author: Dan Smith <[email protected]>
Date:   Wed Apr 28 15:55:31 2021 -0400

    more C APIs exposed through C++ for unit-testing

commit f552322088bd2f22e3045a495850bd96c25ccdfb
Author: Dan Smith <[email protected]>
Date:   Wed Apr 28 15:31:48 2021 -0400

    "Test" project should reference nitf-c, not nitf-c++

commit 66ee139887cb6a7c7764a80097caea46e373f657
Author: Dan Smith <[email protected]>
Date:   Wed Apr 28 15:31:15 2021 -0400

    allow unit-tests to use C++ API rather than direct calls to C

commit 049b9acd7e677f7f8c42301b0ee84f6185166171
Author: Dan Smith <[email protected]>
Date:   Wed Apr 28 15:10:22 2021 -0400

    more tweaks for building as a DLL

commit 1dc4103157c9319885ac81c30efe65659e254374
Author: Dan Smith <[email protected]>
Date:   Wed Apr 28 14:04:16 2021 -0400

    finish separating unit-tests into C and C++

commit d6541484f500c757ccdcaa9cfd091c1040ec8069
Author: Dan Smith <[email protected]>
Date:   Wed Apr 28 13:45:50 2021 -0400

    begin work on separating C and C++ unit-tests

commit 1754c79b68730c81c81da84be67c439c6bb062c5
Author: Dan Smith <[email protected]>
Date:   Wed Apr 28 13:05:46 2021 -0400

    tweak Field::get()

commit c654395457d1557f83f6b1f29e50a77bc8c2d56e
Author: Dan Smith <[email protected]>
Date:   Wed Apr 28 12:46:01 2021 -0400

    add new files to CMakeLists.txt

commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947
Author: Dan Smith <[email protected]>
Date:   Wed Apr 28 12:23:36 2021 -0400

    need to force-resolve the _destruct() functions

commit bb61a5762a38ab4423b2bcb7ec64f013312ed496
Author: Dan Smith <[email protected]>
Date:   Wed Apr 28 10:34:58 2021 -0400

    set path to CODA-OSS libraries

commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33
Author: Dan Smith <[email protected]>
Date:   Wed Apr 28 10:07:40 2021 -0400

    _LIB and _WINDLL are part of Visual Studio, not MSVC

commit b05bd737c9a9d5e2522a5ae14917b3b955708d53
Author: Dan Smith <[email protected]>
Date:   Tue Apr 27 18:01:47 2021 -0400

    remove reference to nitf-c from "Test" project

commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f
Author: Dan Smith <[email protected]>
Date:   Tue Apr 27 17:05:01 2021 -0400

    use NITRO_NITFCPP_API to export classes/functions

commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0
Author: Dan Smith <[email protected]>
Date:   Tue Apr 27 15:36:19 2021 -0400

    Create nitf-c++-dll.vcxproj

commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a
Author: Dan Smith <[email protected]>
Date:   Tue Apr 27 15:07:05 2021 -0400

    infrastructure for exporting symbols from nitf-c++

commit 758f5977222cb1bc833474198eca6e773725dedc
Author: Dan Smith <[email protected]>
Date:   Tue Apr 27 11:23:34 2021 -0400

    adjust CMakeLists.txt to turn on more compiler warnings

commit f5d9c21f568707cd348411bd31bbb405800ca974
Author: Dan Smith <[email protected]>
Date:   Mon Apr 26 14:32:29 2021 -0400

    avoid avoid array -> pointer decay in nitf::Error

commit b682e55713cfedcaae0cafbb52404c666c989aab
Merge: 02f700e4 35c5f4ad
Author: Dan Smith <[email protected]>
Date:   Mon Apr 26 14:29:51 2021 -0400

    Merge branch 'master' into feature/remove_compiler_warnings

commit e55b86ba809b11267c11f4a21fc3ceaf70d25eca
Merge: 12500e5e 35c5f4ad
Author: Dan Smith <[email protected]>
Date:   Mon Apr 26 14:29:38 2021 -0400

    Merge branch 'master' into feature/simplify-cpp-api

commit 02f700e46abebd7a4afcea343696efd71cb4b345
Author: Dan Smith <[email protected]>
Date:   Mon Apr 26 11:22:52 2021 -0400

    ubuntu-latest

commit 12500e5e41ac1dccf03b5ff0f6a7aa95ba6b63f2
Merge: 011c2fa6 273c39e8
Author: Dan Smith <[email protected]>
Date:   Mon Apr 26 11:20:22 2021 -0400

    Merge branch 'master' into feature/simplify-cpp-api

commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d
Merge: 6e6819db 273c39e8
Author: Dan Smith <[email protected]>
Date:   Mon Apr 26 11:20:00 2021 -0400

    Merge branch 'master' into develop/update_coda-oss

commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111
Merge: 40af41a9 273c39e8
Author: Dan Smith <[email protected]>
Date:   Mon Apr 26 11:19:40 2021 -0400

    Merge branch 'master' into feature/remove_compiler_warnings

commit 011c2fa64ff4455456fbe0fe3836bc17e2fdf815
Author: Dan Smith <[email protected]>
Date:   Sat Apr 24 13:01:14 2021 -0400

    create test_extract.cpp that is very similar to nitf_extract.py

commit 40af41a9444cc1bc066080a4b160a26e18ac6fed
Author: Dan Smith <[email protected]>
Date:   Tue Apr 20 10:07:18 2021 -0400

    build with fewer compiler warnings/code-analysis diagnostics

commit 9d4d36651dc570bc45b747b43087e9de675deb15
Merge: cfe591ab 6e6819db
Author: Dan Smith <[email protected]>
Date:   Tue Apr 20 09:57:19 2021 -0400

    Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743
Author: Dan Smith <[email protected]>
Date:   Tue Apr 20 09:57:00 2021 -0400

    latest from coda-oss

commit cfe591ab71072eb672c575f2d1de176ba06cdff9
Author: Dan Smith <[email protected]>
Date:   Mon Apr 19 11:27:40 2021 -0400

    #includes for std::make_unique

commit c150cc2867f35ef63913885e8860826c829f0d53
Author: Dan Smith <[email protected]>
Date:   Mon Apr 19 11:12:03 2021 -0400

    remove more explicit new and delete

commit e3857e573329d9c00889afffc7902d67eaa0f386
Author: Dan Smith <[email protected]>
Date:   Mon Apr 19 10:02:30 2021 -0400

    reduce explicit use of new and delete

commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08
Merge: c7b29b1d 7af8169b
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 16:37:07 2021 -0400

    Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 16:36:48 2021 -0400

    implement ScopedArray with std::unique_ptr<>

commit f5a69e892171f2bad6a1aaa16586517125a46db7
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 16:32:57 2021 -0400

    latest from coda-oss

commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 16:29:32 2021 -0400

    turn on more code-analysis diagnostics

commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2
Merge: bcb6bfc4 4b0062b7
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 15:53:32 2021 -0400

    Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

commit 4b0062b73474bff299b45a2419b19625ddc35e56
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 15:52:21 2021 -0400

    pragmas only for MSVC

commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411
Merge: 6f4befc1 4aa689b9
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 15:45:28 2021 -0400

    Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

commit 4aa689b93c2f8d654ae783911dbaa241324f034a
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 15:45:13 2021 -0400

    latest from coda-oss

commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 15:44:53 2021 -0400

    explicitly =delete copy/assignment

commit e381bc348de5c3dfe1a472ad48b61f44cfccf546
Merge: 1a7b623b fdc62abd
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 15:19:56 2021 -0400

    Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 15:19:40 2021 -0400

    more changes for =default from coda-oss

commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f
Merge: 5d07dd64 014917fe
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 15:01:04 2021 -0400

    Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

commit 014917feef86263980614670a40e77e76963e90a
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 15:00:45 2021 -0400

    =default from coda-oss

commit 5d07dd64afc234e8aec83b1086fe8deb51a12084
Merge: 012b9b4f cd50f937
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 14:47:16 2021 -0400

    Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 14:47:07 2021 -0400

    Update coda-oss.hpp

commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 14:46:07 2021 -0400

    more changes from coda-oss

commit 81b99e75295e4beed74729dddd61b78d1d68ec4d
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 14:45:42 2021 -0400

     PlatformToolset() is no longer used

commit 945e2a284c7a306fb87f8113f18242cc592bbdb8
Merge: b96c0e9c 9532c538
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 14:19:53 2021 -0400

    Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

commit 9532c53866759861d76b2206cbb330eeed761996
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 14:19:43 2021 -0400

    update coda-oss to get code-analysis changes

commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 14:19:22 2021 -0400

    more code-analysis cleanup

commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 13:40:36 2021 -0400

    no import/logging.h

commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51
Merge: 7e54d7e9 32609f76
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 13:07:23 2021 -0400

    Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

commit 32609f761a5483f923d205f5e5e586ac8aff825c
Author: Dan Smith <[email protected]>
Date:   Sat Apr 17 13:06:48 2021 -0400

    update coda-oss to reduce compiler warnings

commit 7e54d7e9221008d883c2da195cf2d3f321f76442
Author: Dan Smith <[email protected]>
Date:   Mon Apr 12 14:04:01 2021 -0400

    wrap nitf_Error to reduce code-analysis diagnostics

commit 18c18a206f95fb078f683c06c71504321cc470a4
Author: Dan Smith <[email protected]>
Date:   Mon Apr 12 13:33:50 2021 -0400

    adjust the code-analysis diagnostics that are disabled

commit e136900ae637eb0a2d9cb282eb03875f32eaad82
Merge: dddbb27b 1ff904eb
Author: Dan Smith <[email protected]>
Date:   Mon Apr 12 13:32:48 2021 -0400

    Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

commit 1ff904eb9f0b7c77898a4150d58669c484d45233
Author: Dan Smith <[email protected]>
Date:   Mon Apr 12 13:32:36 2021 -0400

    remove more code-analysis diagnostics

commit dddbb27b70364ae737bef67f84064ae18409943c
Merge: 8b3483cf 20f4e614
Author: Dan Smith <[email protected]>
Date:   Mon Apr 12 12:43:06 2021 -0400

    Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings

commit 20f4e6142857ce40985b78e0f1439e62b4fc3357
Author: Dan Smith <[email protected]>
Date:   Mon Apr 12 12:42:51 2021 -0400

    update coda-oss to remove compiler warnings

commit f491097a4488f5bbe7ff0654453124d4002d3a77
Merge: 84b3bf57 298536f4
Author: Dan Smith <[email protected]>
Date:   Mon Apr 12 12:40:28 2021 -0400

    Merge branch 'master' into develop/update_coda-oss

commit 8b3483cfe42899487735297a85e83dfa23ea7eff
Author: Dan Smith <[email protected]>
Date:   Mon Apr 12 12:39:12 2021 -0400

    slam in changes from "master"

commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a
Merge: 316cf602 298536f4
Author: Dan Smith <[email protected]>
Date:   Mon Apr 12 12:32:05 2021 -0400

    Merge branch 'master' into feature/remove_compiler_warnings

commit 316cf602098d8a486977897a3d032bcd53accf21
Author: Dan Smith <[email protected]>
Date:   Mon Apr 12 12:31:35 2021 -0400

    PlatformToolset() isn't used

commit 84b3bf57923367a513f9c55a36253582b8697bee
Author: Dan Smith <[email protected]>
Date:   Tue Apr 6 11:22:51 2021 -0400

    changes to python wrappers

commit 4fc…
  • Loading branch information
J. Daniel Smith authored Jul 19, 2023
1 parent de91d49 commit 7a6132b
Show file tree
Hide file tree
Showing 15 changed files with 87 additions and 124 deletions.
1 change: 1 addition & 0 deletions modules/c++/nitf/apps/show_nitf++/pch.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
#pragma warning(disable: 5204) // '...': class has virtual functions, but its trivial destructor is not virtual; instances of objects derived from this class may not be destructed correctly
#pragma warning(disable: 5220) // '...': a non-static data member with a volatile qualified type no longer implies
#pragma warning(disable: 4355) // '...': used in base member initializer list
#pragma warning(disable: 5105) // macro expansion producing '...' has undefined behavior

#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers
#include <windows.h>
Expand Down
4 changes: 1 addition & 3 deletions modules/c++/nitf/unittests/test_hash_table_1++.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,6 @@ TEST_CASE(test_hash_table_iterator)
}

TEST_MAIN(
(void)argc;
(void)argv;
TEST_CHECK(test_hash_table_1);
TEST_CHECK(test_hash_table_iterator);
)
)
82 changes: 39 additions & 43 deletions modules/c++/nitf/unittests/test_load_plugins.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,32 +30,28 @@

#include "TestCase.h"

static void load_plugin(const std::string& testName, const char* tre)
static void retrieveTREHandler(const std::string& testName, const char* tre)
{
nitf_Error error;

auto reg = nitf::PluginRegistry::getInstance(error);
auto const reg = nitf::PluginRegistry::getInstance(error);
TEST_ASSERT(reg != nullptr);

nitf::HashTable::print(*(reg->treHandlers));
//nitf::HashTable::print(*(reg->treHandlers));

int bad = 0;
auto test_main_ =
nitf::PluginRegistry::retrieveTREHandler(*reg,
tre,
bad,
error);
auto const test_main_ = nitf::PluginRegistry::retrieveTREHandler(*reg, tre, bad, error);
TEST_ASSERT_EQ(0, bad);
TEST_ASSERT(test_main_ != nullptr);
}

static const std::vector<std::string>& all_plugins()
static const auto& all_TREs()
{
static const std::vector<std::string> all_plugins_
static const std::vector<std::string> retval
{
#if _MSC_VER && NITRO_PCH
// only build a handful in Visual Studio
"ACCHZB", "ACCPOB", "ACFTA", "AIMIDB", "CSCRNA", "ENGRDA", "HISTOA", "JITCID", "PTPRAA", "RPFHDR",
"ACCHZB", "ACCPOB", "ACFTA", "AIMIDB", "CSCRNA", "CSEXRB", "ENGRDA", "HISTOA", "JITCID", "PTPRAA", "RPFHDR",
#else
"ACCHZB", "BANDSB", "CSDIDA", "GEOLOB", "JITCID", "NBLOCA", "PIAPEB", "REGPTB", "RSMIDA", "STEROB",
"ACCPOB", "BCKGDA", "CSEPHA", "GEOPSB", "MAPLOB", "OBJCTA", "PIAPRC", "RPC00B", "RSMPCA", "STREOB",
Expand All @@ -69,59 +65,59 @@ static const std::vector<std::string>& all_plugins()
"BANDSA", "CSCRNA", "EXPLTB", "J2KLRA", "MTIRPB", "PIAPEA", "PTPRAA", "RSMGIA", "STDIDC",
#endif
};
return all_plugins_;
return retval;
}

TEST_CASE(test_load_all_plugins_C)
TEST_CASE(test_retrieveTREHandler)
{
nitf::Test::setNitfPluginPath();

for (const auto& tre : all_plugins())
for (const auto& tre : all_TREs())
{
load_plugin(testName, tre.c_str());
retrieveTREHandler(testName, tre.c_str());
}
}

TEST_CASE(test_load_PTPRAA)
{
nitf::Test::setNitfPluginPath();
load_plugin(testName, "PTPRAA");
retrieveTREHandler(testName, "PTPRAA");
}
TEST_CASE(test_load_ENGRDA)
{
nitf::Test::setNitfPluginPath();
load_plugin(testName, "ENGRDA");
retrieveTREHandler(testName, "ENGRDA");
}

static void loadPlugin(const std::string& testName, const std::string& path)
{
try
{
#ifdef _WIN32
// need the full path to load on Linux
nitf::PluginRegistry::loadPlugin(path);
#endif
TEST_SUCCESS;
}
catch (const nitf::NITFException& ex)
{
TEST_FAIL_MSG(ex.toString());
}
}
TEST_CASE(test_load_all_plugins)
TEST_CASE(test_load_all_TREs)
{
nitf::Test::setNitfPluginPath();
const nitf::TRE tre("ACCPOB");

for (const auto& tre : all_plugins())
for (const auto& tre : all_TREs())
{
loadPlugin(testName, tre);
// TREs are quite the same thing as an arbitrary "plug in;" the underlying
// infrastructure is all built on shared-libraries/DLLs, but details differ.
//
// As a result, we can't expect loadPlugin() will "just work" on a TRE name.
// Unfortunately, the behavior is different on Windows and Linux. :-(
#if _WIN32
// Keep this around for now as it works ... but it's not necessarily correct.
// Mostly an excuse to exercise more code.
try
{
nitf::PluginRegistry::loadPlugin(tre);
}
catch (const nitf::NITFException& ex)
{
TEST_FAIL_MSG(ex.toString());
}
#endif // _WIN32

TEST_ASSERT(nitf::PluginRegistry::treHandlerExists(tre));
}
}

TEST_MAIN(
nitf::Test::setNitfPluginPath();

TEST_CHECK(test_load_PTPRAA);
TEST_CHECK(test_load_ENGRDA);
TEST_CHECK(test_load_all_plugins_C);
TEST_CHECK(test_load_all_plugins);
TEST_CHECK(test_load_ENGRDA);
TEST_CHECK(test_retrieveTREHandler);
TEST_CHECK(test_load_all_TREs);
)
6 changes: 2 additions & 4 deletions modules/c++/nitf/unittests/test_tre_create++.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

TEST_CASE(test_tre_create_329)
{
nitf::Test::setNitfPluginPath();

// https://github.com/mdaus/nitro/issues/329

nitf::TRE tre("HISTOA", "HISTOA"); // allocates fields SYSTEM .. NEVENTS
Expand All @@ -21,8 +19,6 @@ TEST_CASE(test_tre_create_329)

TEST_CASE(test_tre_clone_329)
{
nitf::Test::setNitfPluginPath();

// https://github.com/mdaus/nitro/issues/329
const std::string rd = "begin1020030004ABCDEFend";

Expand All @@ -43,6 +39,8 @@ TEST_CASE(test_tre_clone_329)
}

TEST_MAIN(
nitf::Test::setNitfPluginPath();

TEST_CHECK(test_tre_create_329);
TEST_CHECK(test_tre_clone_329);
)
22 changes: 2 additions & 20 deletions modules/c++/nitf/unittests/test_tre_mods++.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,6 @@ struct /*namespace*/ TREs

TEST_CASE(setFields)
{
nitf::Test::setNitfPluginPath();

// create an ACFTA TRE
nitf::TRE tre("ACFTA");

Expand All @@ -180,8 +178,6 @@ TEST_CASE(setFields)

TEST_CASE(setBinaryFields)
{
nitf::Test::setNitfPluginPath();

nitf::TRE tre("RPFHDR");
const int value = 123;
tre.setField("LOCSEC", value);
Expand All @@ -193,8 +189,6 @@ TEST_CASE(setBinaryFields)

TEST_CASE(cloneTRE)
{
nitf::Test::setNitfPluginPath();

nitf::TRE tre("JITCID");
tre.setField("FILCMT", "fyi");

Expand All @@ -208,8 +202,6 @@ TEST_CASE(cloneTRE)

TEST_CASE(basicIteration)
{
nitf::Test::setNitfPluginPath();

nitf::TRE tre("ACCPOB");

// The entire TRE is one loop, and we haven't told it
Expand Down Expand Up @@ -237,8 +229,6 @@ TEST_CASE(basicIteration)

TEST_CASE(use_ENGRDA)
{
nitf::Test::setNitfPluginPath();

nitf::TRE engrda("ENGRDA", "ENGRDA");

engrda.setField("RESRC", "HSS");
Expand All @@ -263,8 +253,6 @@ TEST_CASE(use_ENGRDA)

TEST_CASE(use_ENGRDA_typed_fields)
{
nitf::Test::setNitfPluginPath();

nitf::TRE engrda("ENGRDA", "ENGRDA");

nitf::TREField_BCS_A<20> RESRC(engrda, "RESRC");
Expand Down Expand Up @@ -297,8 +285,6 @@ TEST_CASE(use_ENGRDA_typed_fields)

TEST_CASE(use_typed_ENGRDA)
{
nitf::Test::setNitfPluginPath();

TREs::ENGRDA engrda; // nitf::TRE engrda("ENGRDA", "ENGRDA");

engrda.RESRC = "HSS"; // engrda.setField("RESRC", "HSS");
Expand Down Expand Up @@ -347,8 +333,6 @@ TEST_CASE(use_typed_ENGRDA)

TEST_CASE(use_CSEXRB_typed_fields)
{
nitf::Test::setNitfPluginPath();

nitf::TRE tre("CSEXRB", "CSEXRB");

constexpr auto length = 12;
Expand All @@ -362,8 +346,6 @@ TEST_CASE(use_CSEXRB_typed_fields)

TEST_CASE(populateWhileIterating)
{
nitf::Test::setNitfPluginPath();

nitf::TRE tre("ACCPOB");
size_t numFields = 0;
for (auto it = tre.begin(); it != tre.end(); ++it)
Expand All @@ -388,8 +370,6 @@ TEST_CASE(populateWhileIterating)

TEST_CASE(overflowingNumericFields)
{
nitf::Test::setNitfPluginPath();

nitf::TRE tre("CSCRNA");

// This field has a length of 9, so check that it's properly
Expand Down Expand Up @@ -418,6 +398,8 @@ TEST_CASE(overflowingNumericFields)
}

TEST_MAIN(
nitf::Test::setNitfPluginPath();

TEST_CHECK(setFields);
TEST_CHECK(setBinaryFields);
TEST_CHECK(cloneTRE);
Expand Down
18 changes: 2 additions & 16 deletions modules/c++/nitf/unittests/test_tre_mods.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@

TEST_CASE(testNestedMod)
{
nitf::Test::setNitfPluginPath();

nitf_Error error;
NITF_BOOL exists;
nitf_TRE* tre = nitf_TRE_construct("ACCHZB", NULL, &error);
Expand Down Expand Up @@ -61,8 +59,6 @@ TEST_CASE(testNestedMod)

TEST_CASE(testIncompleteCondMod)
{
nitf::Test::setNitfPluginPath();

nitf_Error error;
NITF_BOOL exists;
nitf_TRE* tre = nitf_TRE_construct("ACCPOB", NULL, &error);
Expand All @@ -89,8 +85,6 @@ TEST_CASE(testIncompleteCondMod)

TEST_CASE(testClone)
{
nitf::Test::setNitfPluginPath();

NITF_BOOL exists;
nitf_TRE* dolly; /* used for clone */
nitf_Field* clonedField = NULL;
Expand All @@ -116,8 +110,6 @@ TEST_CASE(testClone)

TEST_CASE(testBasicMod)
{
nitf::Test::setNitfPluginPath();

/* construct a tre */
NITF_BOOL exists;
nitf_Error error;
Expand Down Expand Up @@ -147,8 +139,6 @@ TEST_CASE(testBasicMod)

TEST_CASE(testSize)
{
nitf::Test::setNitfPluginPath();

nitf_Error error;
int treLength;
nitf_TRE* tre = nitf_TRE_construct("AIMIDB", NULL, &error);
Expand All @@ -163,8 +153,6 @@ TEST_CASE(testSize)

TEST_CASE(iterateUnfilled)
{
nitf::Test::setNitfPluginPath();

nitf_Error error;
nitf_TRECursor cursor;
nitf_TRE* tre = nitf_TRE_construct("ACCPOB", NULL, &error);
Expand All @@ -186,8 +174,6 @@ TEST_CASE(iterateUnfilled)

TEST_CASE(populateThenIterate)
{
nitf::Test::setNitfPluginPath();

nitf_Error error;
nitf_TRECursor cursor;
nitf_TRE* tre = nitf_TRE_construct("ACCPOB", NULL, &error);
Expand All @@ -214,8 +200,6 @@ TEST_CASE(populateThenIterate)

TEST_CASE(populateWhileIterating)
{
nitf::Test::setNitfPluginPath();

nitf_Error error;
nitf_TRECursor cursor;
nitf_TRE* tre = nitf_TRE_construct("ACCPOB", NULL, &error);
Expand Down Expand Up @@ -247,6 +231,8 @@ TEST_CASE(populateWhileIterating)
}

TEST_MAIN(
nitf::Test::setNitfPluginPath();

TEST_CHECK(testClone);
TEST_CHECK(testSize);
TEST_CHECK(testBasicMod);
Expand Down
3 changes: 2 additions & 1 deletion modules/c++/nitf/unittests/test_writer_3++.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include <gsl/gsl.h>

#include <import/nitf.hpp>
#include <nitf/UnitTests.hpp>

#include "TestCase.h"

Expand Down Expand Up @@ -268,4 +269,4 @@ TEST_CASE(test_buffered_write_)
TEST_MAIN(
TEST_CHECK(test_writer_3_);
TEST_CHECK(test_buffered_write_);
)
)
1 change: 1 addition & 0 deletions modules/c++/pch.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ CODA_OSS_disable_warning_pop
#define NOMINMAX
#pragma warning(push)
#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception.
#pragma warning(disable: 5105) // macro expansion producing '...' has undefined behavior
#include <windows.h>
#pragma warning(pop)

Expand Down
Loading

0 comments on commit 7a6132b

Please sign in to comment.