update files changes in cpp17 branch

modules/c++/nitf/apps/show_nitf++/pch.h

@@ -41,6 +41,7 @@
 #pragma warning(disable: 5204) // '...': class has virtual functions, but its trivial destructor is not virtual; instances of objects derived from this class may not be destructed correctly
 #pragma warning(disable: 5220) // '...': a non-static data member with a volatile qualified type no longer implies
 #pragma warning(disable: 4355) // '...': used in base member initializer list
+#pragma warning(disable: 5105) // macro expansion producing '...' has undefined behavior
 
 #define WIN32_LEAN_AND_MEAN             // Exclude rarely-used stuff from Windows headers
 #include <windows.h>

modules/c++/nitf/unittests/test_hash_table_1++.cpp

@@ -151,8 +151,6 @@ TEST_CASE(test_hash_table_iterator)
 }
 
 TEST_MAIN(
-    (void)argc;
-    (void)argv;
     TEST_CHECK(test_hash_table_1);
     TEST_CHECK(test_hash_table_iterator);
-)
+)

modules/c++/nitf/unittests/test_load_plugins.cpp

@@ -30,32 +30,28 @@
 
 #include "TestCase.h"
 
-static void load_plugin(const std::string& testName, const char* tre)
+static void retrieveTREHandler(const std::string& testName, const char* tre)
 {
     nitf_Error error;
 
-    auto reg = nitf::PluginRegistry::getInstance(error);
+    auto const reg = nitf::PluginRegistry::getInstance(error);
     TEST_ASSERT(reg != nullptr);
 
-    nitf::HashTable::print(*(reg->treHandlers));
+    //nitf::HashTable::print(*(reg->treHandlers));
 
     int bad = 0;
-    auto test_main_ =
-        nitf::PluginRegistry::retrieveTREHandler(*reg,
-            tre,
-            bad,
-            error);
+    auto const test_main_ = nitf::PluginRegistry::retrieveTREHandler(*reg, tre, bad, error);
     TEST_ASSERT_EQ(0, bad);
     TEST_ASSERT(test_main_ != nullptr);
 }
 
-static const std::vector<std::string>& all_plugins()
+static const auto& all_TREs()
 {
-    static const std::vector<std::string> all_plugins_
+    static const std::vector<std::string> retval
     {
     #if _MSC_VER && NITRO_PCH
         // only build a handful in Visual Studio
-        "ACCHZB", "ACCPOB", "ACFTA", "AIMIDB", "CSCRNA", "ENGRDA", "HISTOA", "JITCID", "PTPRAA", "RPFHDR",
+        "ACCHZB", "ACCPOB", "ACFTA", "AIMIDB", "CSCRNA", "CSEXRB", "ENGRDA", "HISTOA", "JITCID", "PTPRAA", "RPFHDR",
     #else
         "ACCHZB", "BANDSB", "CSDIDA", "GEOLOB", "JITCID", "NBLOCA", "PIAPEB", "REGPTB", "RSMIDA", "STEROB",
         "ACCPOB", "BCKGDA", "CSEPHA", "GEOPSB", "MAPLOB", "OBJCTA", "PIAPRC", "RPC00B", "RSMPCA", "STREOB",
@@ -69,59 +65,59 @@ static const std::vector<std::string>& all_plugins()
         "BANDSA", "CSCRNA", "EXPLTB", "J2KLRA", "MTIRPB", "PIAPEA", "PTPRAA", "RSMGIA", "STDIDC",
     #endif
     };
-    return all_plugins_;
+    return retval;
 }
 
-TEST_CASE(test_load_all_plugins_C)
+TEST_CASE(test_retrieveTREHandler)
 {
-    nitf::Test::setNitfPluginPath();
-
-    for (const auto& tre : all_plugins())
+    for (const auto& tre : all_TREs())
     {
-        load_plugin(testName, tre.c_str());
+        retrieveTREHandler(testName, tre.c_str());
     }
 }
 
 TEST_CASE(test_load_PTPRAA)
 {
-    nitf::Test::setNitfPluginPath();
-    load_plugin(testName, "PTPRAA");
+    retrieveTREHandler(testName, "PTPRAA");
 }
 TEST_CASE(test_load_ENGRDA)
 {
-    nitf::Test::setNitfPluginPath();
-    load_plugin(testName, "ENGRDA");
+    retrieveTREHandler(testName, "ENGRDA");
 }
 
-static void loadPlugin(const std::string& testName, const std::string& path)
-{
-    try
-    {
-#ifdef _WIN32
-        // need the full path to load on Linux
-        nitf::PluginRegistry::loadPlugin(path);
-#endif
-        TEST_SUCCESS;
-    }
-    catch (const nitf::NITFException& ex)
-    {
-        TEST_FAIL_MSG(ex.toString());
-    }
-}
-TEST_CASE(test_load_all_plugins)
+TEST_CASE(test_load_all_TREs)
 {
-    nitf::Test::setNitfPluginPath();
+    const nitf::TRE tre("ACCPOB");
 
-    for (const auto& tre : all_plugins())
+    for (const auto& tre : all_TREs())
     {
-        loadPlugin(testName, tre);
+        // TREs are quite the same thing as an arbitrary "plug in;" the underlying
+        // infrastructure is all built on shared-libraries/DLLs, but details differ.
+        //
+        // As a result, we can't expect loadPlugin() will "just work" on a TRE name.
+        // Unfortunately, the behavior is different on Windows and Linux. :-(
+        #if _WIN32
+        // Keep this around for now as it works ... but it's not necessarily correct.
+        // Mostly an excuse to exercise more code.
+        try
+        {
+            nitf::PluginRegistry::loadPlugin(tre);
+        }
+        catch (const nitf::NITFException& ex)
+        {
+            TEST_FAIL_MSG(ex.toString());
+        }
+        #endif // _WIN32
+
         TEST_ASSERT(nitf::PluginRegistry::treHandlerExists(tre));
     }
 }
 
 TEST_MAIN(
+    nitf::Test::setNitfPluginPath();
+
     TEST_CHECK(test_load_PTPRAA);
-    TEST_CHECK(test_load_ENGRDA);
-    TEST_CHECK(test_load_all_plugins_C);
-    TEST_CHECK(test_load_all_plugins);
+    TEST_CHECK(test_load_ENGRDA);    
+    TEST_CHECK(test_retrieveTREHandler);
+    TEST_CHECK(test_load_all_TREs);
 )

modules/c++/nitf/unittests/test_tre_create++.cpp

@@ -7,8 +7,6 @@
 
 TEST_CASE(test_tre_create_329)
 {
-    nitf::Test::setNitfPluginPath();
-
     // https://github.com/mdaus/nitro/issues/329
 
     nitf::TRE tre("HISTOA", "HISTOA"); // allocates fields SYSTEM .. NEVENTS
@@ -21,8 +19,6 @@ TEST_CASE(test_tre_create_329)
 
 TEST_CASE(test_tre_clone_329)
 {
-    nitf::Test::setNitfPluginPath();
-
     // https://github.com/mdaus/nitro/issues/329
     const std::string rd = "begin1020030004ABCDEFend";
 
@@ -43,6 +39,8 @@ TEST_CASE(test_tre_clone_329)
 }
 
 TEST_MAIN(
+    nitf::Test::setNitfPluginPath();
+
     TEST_CHECK(test_tre_create_329);
     TEST_CHECK(test_tre_clone_329);
     )

modules/c++/nitf/unittests/test_tre_mods++.cpp

@@ -159,8 +159,6 @@ struct /*namespace*/ TREs
 
 TEST_CASE(setFields)
 {
-    nitf::Test::setNitfPluginPath();
-
     // create an ACFTA TRE
     nitf::TRE tre("ACFTA");
 
@@ -180,8 +178,6 @@ TEST_CASE(setFields)
 
 TEST_CASE(setBinaryFields)
 {
-    nitf::Test::setNitfPluginPath();
-
     nitf::TRE tre("RPFHDR");
     const int value = 123;
     tre.setField("LOCSEC", value);
@@ -193,8 +189,6 @@ TEST_CASE(setBinaryFields)
 
 TEST_CASE(cloneTRE)
 {
-    nitf::Test::setNitfPluginPath();
-
     nitf::TRE tre("JITCID");
     tre.setField("FILCMT", "fyi");
 
@@ -208,8 +202,6 @@ TEST_CASE(cloneTRE)
 
 TEST_CASE(basicIteration)
 {
-    nitf::Test::setNitfPluginPath();
-
     nitf::TRE tre("ACCPOB");
 
     // The entire TRE is one loop, and we haven't told it
@@ -237,8 +229,6 @@ TEST_CASE(basicIteration)
 
 TEST_CASE(use_ENGRDA)
 {
-    nitf::Test::setNitfPluginPath();
-
     nitf::TRE engrda("ENGRDA", "ENGRDA");
 
     engrda.setField("RESRC", "HSS");
@@ -263,8 +253,6 @@ TEST_CASE(use_ENGRDA)
 
 TEST_CASE(use_ENGRDA_typed_fields)
 {
-    nitf::Test::setNitfPluginPath();
-
     nitf::TRE engrda("ENGRDA", "ENGRDA");
 
     nitf::TREField_BCS_A<20> RESRC(engrda, "RESRC");
@@ -297,8 +285,6 @@ TEST_CASE(use_ENGRDA_typed_fields)
 
 TEST_CASE(use_typed_ENGRDA)
 {
-    nitf::Test::setNitfPluginPath();
-
     TREs::ENGRDA engrda; // nitf::TRE engrda("ENGRDA", "ENGRDA");
 
     engrda.RESRC = "HSS"; // engrda.setField("RESRC", "HSS");
@@ -347,8 +333,6 @@ TEST_CASE(use_typed_ENGRDA)
 
 TEST_CASE(use_CSEXRB_typed_fields)
 {
-    nitf::Test::setNitfPluginPath();
-
     nitf::TRE tre("CSEXRB", "CSEXRB");
 
     constexpr auto length = 12;
@@ -362,8 +346,6 @@ TEST_CASE(use_CSEXRB_typed_fields)
 
 TEST_CASE(populateWhileIterating)
 {
-    nitf::Test::setNitfPluginPath();
-
     nitf::TRE tre("ACCPOB");
     size_t numFields = 0;
     for (auto it = tre.begin(); it != tre.end(); ++it)
@@ -388,8 +370,6 @@ TEST_CASE(populateWhileIterating)
 
 TEST_CASE(overflowingNumericFields)
 {
-    nitf::Test::setNitfPluginPath();
-
     nitf::TRE tre("CSCRNA");
 
     // This field has a length of 9, so check that it's properly
@@ -418,6 +398,8 @@ TEST_CASE(overflowingNumericFields)
 }
 
 TEST_MAIN(
+    nitf::Test::setNitfPluginPath();
+
     TEST_CHECK(setFields);
     TEST_CHECK(setBinaryFields);
     TEST_CHECK(cloneTRE);

modules/c++/nitf/unittests/test_tre_mods.cpp

@@ -26,8 +26,6 @@
 
 TEST_CASE(testNestedMod)
 {
-    nitf::Test::setNitfPluginPath();
-
     nitf_Error error;
     NITF_BOOL exists;
     nitf_TRE* tre = nitf_TRE_construct("ACCHZB", NULL, &error);
@@ -61,8 +59,6 @@ TEST_CASE(testNestedMod)
 
 TEST_CASE(testIncompleteCondMod)
 {
-    nitf::Test::setNitfPluginPath();
-
     nitf_Error error;
     NITF_BOOL exists;
     nitf_TRE* tre = nitf_TRE_construct("ACCPOB", NULL, &error);
@@ -89,8 +85,6 @@ TEST_CASE(testIncompleteCondMod)
 
 TEST_CASE(testClone)
 {
-    nitf::Test::setNitfPluginPath();
-
     NITF_BOOL exists;
     nitf_TRE* dolly;            /* used for clone */
     nitf_Field* clonedField = NULL;
@@ -116,8 +110,6 @@ TEST_CASE(testClone)
 
 TEST_CASE(testBasicMod)
 {
-    nitf::Test::setNitfPluginPath();
-
     /* construct a tre */
     NITF_BOOL exists;
     nitf_Error error;
@@ -147,8 +139,6 @@ TEST_CASE(testBasicMod)
 
 TEST_CASE(testSize)
 {
-    nitf::Test::setNitfPluginPath();
-
     nitf_Error error;
     int treLength;
     nitf_TRE* tre = nitf_TRE_construct("AIMIDB", NULL, &error);
@@ -163,8 +153,6 @@ TEST_CASE(testSize)
 
 TEST_CASE(iterateUnfilled)
 {
-    nitf::Test::setNitfPluginPath();
-
     nitf_Error error;
     nitf_TRECursor cursor;
     nitf_TRE* tre = nitf_TRE_construct("ACCPOB", NULL, &error);
@@ -186,8 +174,6 @@ TEST_CASE(iterateUnfilled)
 
 TEST_CASE(populateThenIterate)
 {
-    nitf::Test::setNitfPluginPath();
-
     nitf_Error error;
     nitf_TRECursor cursor;
     nitf_TRE* tre = nitf_TRE_construct("ACCPOB", NULL, &error);
@@ -214,8 +200,6 @@ TEST_CASE(populateThenIterate)
 
 TEST_CASE(populateWhileIterating)
 {
-    nitf::Test::setNitfPluginPath();
-
     nitf_Error error;
     nitf_TRECursor cursor;
     nitf_TRE* tre = nitf_TRE_construct("ACCPOB", NULL, &error);
@@ -247,6 +231,8 @@ TEST_CASE(populateWhileIterating)
 }
 
 TEST_MAIN(
+    nitf::Test::setNitfPluginPath();
+
     TEST_CHECK(testClone);
     TEST_CHECK(testSize);
     TEST_CHECK(testBasicMod);

modules/c++/nitf/unittests/test_writer_3++.cpp

@@ -28,6 +28,7 @@
 #include <gsl/gsl.h>
 
 #include <import/nitf.hpp>
+#include <nitf/UnitTests.hpp>
 
 #include "TestCase.h"
 
@@ -268,4 +269,4 @@ TEST_CASE(test_buffered_write_)
 TEST_MAIN(
     TEST_CHECK(test_writer_3_);
     TEST_CHECK(test_buffered_write_);
-    )
+    )

modules/c++/pch.h

@@ -28,6 +28,7 @@ CODA_OSS_disable_warning_pop
 #define NOMINMAX
 #pragma warning(push)
 #pragma warning(disable: 5039) //	'...': pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception.
+#pragma warning(disable: 5105) // macro expansion producing '...' has undefined behavior
 #include <windows.h>
 #pragma warning(pop)