mdaus · JDanielSmith · Nov 15, 2023 · Apr 4, 2022 · Apr 5, 2022 · Apr 5, 2022
diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj
@@ -55,7 +55,7 @@
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
     <ClCompile>
       <PrecompiledHeader>Use</PrecompiledHeader>
-      <WarningLevel>Level3</WarningLevel>
+      <WarningLevel>Level4</WarningLevel>
       <SDLCheck>true</SDLCheck>
       <AdditionalIncludeDirectories>$(ProjectDir);$(SolutionDir)modules\c\nrt\include;$(SolutionDir)modules\c\nitf\include;$(SolutionDir)modules\c++\nitf\include;$(SolutionDir)modules\c\j2k\include;$(SolutionDir)modules\c;$(SolutionDir)modules\c++;$(SolutionDir)externals\coda-oss\modules\c++;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
       <PreprocessorDefinitions>_DEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>

diff --git a/externals/coda-oss/modules/c++/CMakeLists.txt b/externals/coda-oss/modules/c++/CMakeLists.txt
@@ -3,8 +3,11 @@ set(TARGET_LANGUAGE c++)
 if (MSVC)
     # By default, there is a /W3 on the command-line from somewhere (?); adding
     # /Wn results in a compiler warning.
-    #add_compile_options(/W4) # /Wall
-    string(REGEX REPLACE "/W[0-4]" "/W4" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}") # /Wall
+    #
+    # https://github.com/microsoft/STL/wiki/Changelog#vs-2022-179-preview-1
+    # > *Note*: `/Wall` is not intended for regular production use, as it contains a large number of
+    # > extremely noisy and low-value warnings. In general, the STL does not attempt to be `/Wall` clean.
+    string(REGEX REPLACE "/W[0-4]" "/W4" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}") # add_compile_options(/W4)
 
 elseif (UNIX)
     # https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html

diff --git a/externals/coda-oss/modules/c++/coda-oss.vcxproj b/externals/coda-oss/modules/c++/coda-oss.vcxproj
@@ -564,7 +564,7 @@
   </PropertyGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
     <ClCompile>
-      <WarningLevel>EnableAllWarnings</WarningLevel>
+      <WarningLevel>Level4</WarningLevel>
       <SDLCheck>true</SDLCheck>
       <PreprocessorDefinitions>_DEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1</PreprocessorDefinitions>
       <ForcedIncludeFiles>pch.h</ForcedIncludeFiles>
@@ -593,7 +593,6 @@
   </ItemDefinitionGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
     <ClCompile>
-      <WarningLevel>Level3</WarningLevel>
       <FunctionLevelLinking>true</FunctionLevelLinking>
       <IntrinsicFunctions>true</IntrinsicFunctions>
       <SDLCheck>true</SDLCheck>
@@ -609,6 +608,7 @@
       <ConformanceMode>true</ConformanceMode>
       <AdditionalOptions>/Zc:__cplusplus %(AdditionalOptions)</AdditionalOptions>
       <EnableEnhancedInstructionSet>AdvancedVectorExtensions2</EnableEnhancedInstructionSet>
+      <WarningLevel>Level3</WarningLevel>
     </ClCompile>
     <Link>
       <SubSystem>

diff --git a/externals/coda-oss/modules/c++/str/include/str/Convert.h b/externals/coda-oss/modules/c++/str/include/str/Convert.h
@@ -63,7 +63,7 @@ std::string toString_(const T& value)
     return buf.str();
 }
 template <typename T>
-inline auto toString(const T& value)
+inline std::string toString(const T& value)
 {
     return toString_(value);
 }
@@ -105,6 +105,7 @@ inline auto toString(long double value)
 {
     return toString_(value);
 }
+
 inline std::string toString(uint8_t value)
 {
     return toString(gsl::narrow<unsigned int>(value));

diff --git a/externals/coda-oss/modules/c++/str/source/Convert.cpp b/externals/coda-oss/modules/c++/str/source/Convert.cpp
@@ -42,32 +42,25 @@ template<> std::string str::toType<std::string>(const std::string& s)
 
 template<> bool str::toType<bool>(const std::string& s)
 {
-    std::string ss = s;
-    str::lower(ss);
-
-    if (ss == "true")
+    if (eq(s, "true")) // case-insensitive compare
     {
         return true;
     }
-    else if (ss == "false")
+    if (eq(s, "false"))  // case-insensitive compare
     {
         return false;
     }
-    else if (str::isNumeric(ss))
+
+    // no need for lower(), digits don't have case
+    if (str::isNumeric(s))
     {
         int value(0);
-        std::stringstream buf(ss);
+        std::stringstream buf(s);
         buf >> value;
         return (value != 0);
     }
-    else
-    {
-        throw except::BadCastException(except::Context(__FILE__, __LINE__,
-            std::string(""), std::string(""),
-            std::string("Invalid bool: '") + s + std::string("'")));
-    }
 
-    return false;
+    throw except::BadCastException(except::Context(__FILE__, __LINE__, "", "", "Invalid bool: '" + s + "'"));
 }
 
 long long str::strtoll(const char *str, char **endptr, int base)

diff --git a/modules/c++/CMakeLists.txt b/modules/c++/CMakeLists.txt
@@ -3,9 +3,12 @@ set(TARGET_LANGUAGE c++)
 # turn on warnings as errors
 if (MSVC)
     # By default, there is a /W3 on the command-line from somewhere (?); adding
-    # /W4 results in a compiler warning.
-    #add_compile_options(/W4) # /Wall
-    string(REGEX REPLACE "/W[0-4]" "/W4" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}") # /Wall
+    # /Wn results in a compiler warning.
+    #
+    # https://github.com/microsoft/STL/wiki/Changelog#vs-2022-179-preview-1
+    # > *Note*: `/Wall` is not intended for regular production use, as it contains a large number of
+    # > extremely noisy and low-value warnings. In general, the STL does not attempt to be `/Wall` clean.
+    string(REGEX REPLACE "/W[0-4]" "/W4" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}") # add_compile_options(/W4)
 
 elseif (UNIX)
     #add_compile_options(-Wall -pedantic -Wextra)

diff --git a/modules/c++/nitf-c++.vcxproj b/modules/c++/nitf-c++.vcxproj
@@ -214,7 +214,7 @@
   </PropertyGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
     <ClCompile>
-      <WarningLevel>EnableAllWarnings</WarningLevel>
+      <WarningLevel>Level4</WarningLevel>
       <SDLCheck>true</SDLCheck>
       <PreprocessorDefinitions>_DEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <ConformanceMode>true</ConformanceMode>
@@ -233,6 +233,7 @@
       <EnableEnhancedInstructionSet>AdvancedVectorExtensions2</EnableEnhancedInstructionSet>
       <RuntimeLibrary>MultiThreadedDebugDLL</RuntimeLibrary>
       <RuntimeTypeInfo>true</RuntimeTypeInfo>
+      <TreatWarningAsError>true</TreatWarningAsError>
     </ClCompile>
     <Link>
       <SubSystem>

diff --git a/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj b/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj
@@ -47,7 +47,7 @@
   </PropertyGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
     <ClCompile>
-      <WarningLevel>EnableAllWarnings</WarningLevel>
+      <WarningLevel>Level4</WarningLevel>
       <SDLCheck>true</SDLCheck>
       <PreprocessorDefinitions>_DEBUG;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <ConformanceMode>true</ConformanceMode>
@@ -65,6 +65,7 @@
       <SupportJustMyCode>true</SupportJustMyCode>
       <EnableEnhancedInstructionSet>AdvancedVectorExtensions2</EnableEnhancedInstructionSet>
       <RuntimeTypeInfo>true</RuntimeTypeInfo>
+      <TreatWarningAsError>true</TreatWarningAsError>
     </ClCompile>
     <Link>
       <SubSystem>Console</SubSystem>

diff --git a/modules/c++/nitf/source/UnitTests.cpp b/modules/c++/nitf/source/UnitTests.cpp
@@ -271,7 +271,7 @@ static std::string buildPluginName(const std::string& base)
 void nitf::Test::setNitfPluginPath()
 {
 	// The name of the plugin we know exists and will always be built, see test_load_plugins
-	static const auto p = getNitfPluginPath(buildPluginName("XML_DATA_CONTENT"));
+	static const auto p = getNitfPluginPath(buildPluginName("TEST_DES"));
 	sys::OS().setEnv("NITF_PLUGIN_PATH", p.string(), true /*overwrite*/);	
 }
 

diff --git a/modules/c++/nitf/unittests/test_load_plugins.cpp b/modules/c++/nitf/unittests/test_load_plugins.cpp
@@ -87,7 +87,7 @@ TEST_CASE(test_load_ENGRDA)
 
 TEST_CASE(test_load_all_TREs)
 {
-    const nitf::TRE tre("ACCPOB");
+    const nitf::TRE ACCPOB("ACCPOB");
 
     for (const auto& tre : all_TREs())
     {

diff --git a/modules/c/CMakeLists.txt b/modules/c/CMakeLists.txt
@@ -4,9 +4,12 @@ set(TARGET_LANGUAGE c)
 # turn on warnings as errors
 if (MSVC)
     # By default, there is a /W3 on the command-line from somewhere (?); adding
-    # /W4 results in a compiler warning.
-    #add_compile_options(/W4) # /Wall
-    string(REGEX REPLACE "/W[0-4]" "/W4" CMAKE_C_FLAGS "${CMAKE_C_FLAGS}") # /Wall
+    # /Wn results in a compiler warning.
+    #
+    # https://github.com/microsoft/STL/wiki/Changelog#vs-2022-179-preview-1
+    # > *Note*: `/Wall` is not intended for regular production use, as it contains a large number of
+    # > extremely noisy and low-value warnings. In general, the STL does not attempt to be `/Wall` clean.
+    string(REGEX REPLACE "/W[0-4]" "/W4" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}") # add_compile_options(/W4)
 
     add_compile_options(/wd4996) # '...': This function or variable may be unsafe.
 elseif (UNIX)

diff --git a/modules/c/j2k/J2KCompress.vcxproj b/modules/c/j2k/J2KCompress.vcxproj
@@ -62,7 +62,7 @@
   </PropertyGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
     <ClCompile>
-      <WarningLevel>EnableAllWarnings</WarningLevel>
+      <WarningLevel>Level4</WarningLevel>
       <SDLCheck>true</SDLCheck>
       <PreprocessorDefinitions>_DEBUG;_LIB;%(PreprocessorDefinitions);NRT_MODULE_EXPORTS;NITRO_PCH;HAVE_J2K_H</PreprocessorDefinitions>
       <ConformanceMode>true</ConformanceMode>

diff --git a/modules/c/j2k/J2KDecompress.vcxproj b/modules/c/j2k/J2KDecompress.vcxproj
@@ -62,7 +62,7 @@
   </PropertyGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
     <ClCompile>
-      <WarningLevel>EnableAllWarnings</WarningLevel>
+      <WarningLevel>Level4</WarningLevel>
       <SDLCheck>true</SDLCheck>
       <PreprocessorDefinitions>_DEBUG;_LIB;%(PreprocessorDefinitions);NRT_MODULE_EXPORTS;NITRO_PCH;HAVE_J2K_H</PreprocessorDefinitions>
       <ConformanceMode>true</ConformanceMode>

diff --git a/modules/c/nitf-c.vcxproj b/modules/c/nitf-c.vcxproj
@@ -48,7 +48,7 @@
   </PropertyGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
     <ClCompile>
-      <WarningLevel>EnableAllWarnings</WarningLevel>
+      <WarningLevel>Level4</WarningLevel>
       <SDLCheck>true</SDLCheck>
       <PreprocessorDefinitions>_DEBUG;%(PreprocessorDefinitions);HAVE_OPENJPEG_H</PreprocessorDefinitions>
       <ConformanceMode>true</ConformanceMode>
@@ -68,6 +68,7 @@
       <ExceptionHandling>false</ExceptionHandling>
       <RuntimeLibrary>MultiThreadedDebugDLL</RuntimeLibrary>
       <RuntimeTypeInfo>true</RuntimeTypeInfo>
+      <TreatWarningAsError>true</TreatWarningAsError>
     </ClCompile>
     <Link>
       <SubSystem>

diff --git a/modules/c/nitf/TEST_DES.vcxproj b/modules/c/nitf/TEST_DES.vcxproj
@@ -62,7 +62,7 @@
   </PropertyGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
     <ClCompile>
-      <WarningLevel>EnableAllWarnings</WarningLevel>
+      <WarningLevel>Level4</WarningLevel>
       <SDLCheck>true</SDLCheck>
       <PreprocessorDefinitions>_DEBUG;_LIB;%(PreprocessorDefinitions);NRT_MODULE_EXPORTS;NITRO_PCH</PreprocessorDefinitions>
       <ConformanceMode>true</ConformanceMode>

diff --git a/modules/c/nitf/XML_DATA_CONTENT.vcxproj b/modules/c/nitf/XML_DATA_CONTENT.vcxproj
@@ -62,7 +62,7 @@
   </PropertyGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
     <ClCompile>
-      <WarningLevel>EnableAllWarnings</WarningLevel>
+      <WarningLevel>Level4</WarningLevel>
       <SDLCheck>true</SDLCheck>
       <PreprocessorDefinitions>_DEBUG;_LIB;%(PreprocessorDefinitions);NRT_MODULE_EXPORTS;NITRO_PCH</PreprocessorDefinitions>
       <ConformanceMode>true</ConformanceMode>