-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
252 [Back] Add flask socketio #269
base: dev
Are you sure you want to change the base?
Conversation
|
We should just implented websocket for messages updating in the current room ( or maybe every room where the user is added) |
Add websocket for :
And we needed to add this fonctionnality in the service.ts and use it in the application |
So, summary of what needs to be done with websockets: The server should handle rooms like so: When a user "goes" into a room (channel), it should send a join event, the server then places the user in the right socketio room. Then when a user sends a message, the server should react by sending a message event to everyone in the room (except for the sending user, with The server should also send events informing that a user has joined/left (The user clicked in/off or logged off) the current room. The server should also now keep track of which user is writing, probably not in the Database, but maybe in a big EventsFrom server to client(s)
From client to server
Questions
Also see middlewares for auth, even if we won't run any actual check on the backend, we need to be able to associate a websocket connection and a scratchy user. |
i have implemented socketio on the method to get room, @yannis-mlgrn or @viandoxdev could you test if it work on the js side (normally by creating a socket and sending the message "get" you should get the room)