Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF104 HTMLElement.focus() param focusVisible #17278

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

hamishwillee
Copy link
Contributor

FF104 adds support for HTMLElement.focus() param focusVisible in https://bugzilla.mozilla.org/show_bug.cgi?id=1765083.

This is not supported in chromium or webkit yet, though there are bugs https://bugs.chromium.org/p/chromium/issues/detail?id=1317039 and https://bugs.webkit.org/show_bug.cgi?id=242456

Related docs work can be tracked in mdn/content#19302

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Aug 9, 2022
@hamishwillee
Copy link
Contributor Author

hamishwillee commented Aug 9, 2022

@queengooborg Can you please review this PR.

Note, I ran npm install but I'm getting these errors on windows. Any thoughts?

...
  24:1  warning  Missing JSDoc @returns description       jsdoc/require-returns-description
  29:1  warning  Missing JSDoc block description          jsdoc/require-description
  31:1  warning  Missing JSDoc @param "data" description  jsdoc/require-param-description
  32:1  warning  Missing JSDoc @returns description       jsdoc/require-returns-description

✖ 400 problems (0 errors, 400 warnings)

Checking formatting...
All matched files use Prettier code style!

> @mdn/[email protected] lint
> ts-node test/lint.ts

(node:44296) ExperimentalWarning: Importing JSON modules is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Loading and checking files...
Testing browser data...
Testing feature data...
Testing all features together...
Filename - 44 problems (44 errors, 0 warnings):
 ✖ api\Console.json - Error → Expected only "api.Console" but found "api.console"
 ✖ api\_globals\atob.json - Error → Expected only "api._globals" but found "api.atob"
 ✖ api\_globals\btoa.json - Error → Expected only "api._globals" but found "api.btoa"
 ✖ api\_globals\caches.json - Error → Expected only "api._globals" but found "api.caches"

Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR itself is LGTM!

@queengooborg queengooborg merged commit 6b13c1e into mdn:main Aug 9, 2022
@hamishwillee
Copy link
Contributor Author

Thanks for the review!

@hamishwillee hamishwillee deleted the ff104_htmlelement_focus_option branch August 9, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants