Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exportFunction and cloneInto #22767

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Add exportFunction and cloneInto #22767

merged 1 commit into from
Sep 25, 2024

Conversation

rebloor
Copy link
Collaborator

@rebloor rebloor commented Apr 4, 2024

Summary

BCD to support documentation of exportFunction and cloneInto in mdn/content#30877

@rebloor rebloor added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Apr 4, 2024
@rebloor rebloor requested a review from Rob--W April 4, 2024 03:00
@rebloor rebloor self-assigned this Apr 4, 2024
@rebloor rebloor marked this pull request as ready for review September 25, 2024 02:27
@rebloor rebloor merged commit 7bfeb54 into mdn:main Sep 25, 2024
5 checks passed
@rebloor rebloor deleted the components.utils branch September 25, 2024 02:28
},
"edge": "mirror",
"firefox": {
"version_added": true
Copy link
Contributor

@danielhjacobs danielhjacobs Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This added three instances of "version_added": true, which @queengooborg is on a mission to remove. Do you know the version that added this so these files can be updated?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we should not be adding any more version_added: true statements into BCD, and instead focusing on adding proper versions. A ranged value can be used in these cases when you know a feature was available in some version, but may have been added later!

Copy link
Contributor

@danielhjacobs danielhjacobs Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing these functions may have existed since after the blog on April 10, 2014: https://blog.mozilla.org/addons/2014/04/10/changes-to-unsafewindow-for-the-add-on-sdk/. @Rob--W can you confirm? According to that blog, this was introduced in Firefox 30.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #24521

},
"edge": "mirror",
"firefox": {
"version_added": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second instance of "version_added": true

},
"edge": "mirror",
"firefox": {
"version_added": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third instance of "version_added": true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants