-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exportFunction and cloneInto #22767
Conversation
}, | ||
"edge": "mirror", | ||
"firefox": { | ||
"version_added": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This added three instances of "version_added": true
, which @queengooborg is on a mission to remove. Do you know the version that added this so these files can be updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we should not be adding any more version_added: true
statements into BCD, and instead focusing on adding proper versions. A ranged value can be used in these cases when you know a feature was available in some version, but may have been added later!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing these functions may have existed since after the blog on April 10, 2014: https://blog.mozilla.org/addons/2014/04/10/changes-to-unsafewindow-for-the-add-on-sdk/. @Rob--W can you confirm? According to that blog, this was introduced in Firefox 30.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #24521
}, | ||
"edge": "mirror", | ||
"firefox": { | ||
"version_added": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second instance of "version_added": true
}, | ||
"edge": "mirror", | ||
"firefox": { | ||
"version_added": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Third instance of "version_added": true
Summary
BCD to support documentation of exportFunction and cloneInto in mdn/content#30877